feat(package/gqty): reduce bundle size with ohash over object-hash #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@gqty/cli |
4.2.3-canary-20250208053558.0ab6a367f81bfd782b093b739d06ad677f6c43f4 |
npm ↗︎ unpkg ↗︎ |
gqty |
3.4.0-canary-20250208053558.0ab6a367f81bfd782b093b739d06ad677f6c43f4 |
npm ↗︎ unpkg ↗︎ |
vicary
force-pushed
the
feat(package/gqty)/ohash
branch
7 times, most recently
from
8383028 to
da00f87
Compare
kleberbaum
approved these changes
Feb 6, 2025
|
Hi, @kleberbaum. This PR is waiting for @schettn to test the resulting bundle size, does your approve implies a positive test result? |
vicary
force-pushed
the
feat(package/gqty)/ohash
branch
from
da00f87 to
644ad9f
Compare
|
I have read the changes, but have not tested them yet, they looked alright tho. Switching to ohash should reduce bundle size and switching from sha1 to sha256 is also ok. |
|
@vicary looks good 
|
vicary
force-pushed
the
feat(package/gqty)/ohash
branch
from
644ad9f to
0ab6a36
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.