Patch js script #154
Open
Patch js script #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to documentation we can change 'subwidget_form' to any build in or custom widget.
This option doesn't work because line 29-32 in querySelector is hardcoded looking for input field, and don't have any protection in case when it doesn't find it, so script throws error when it's trying getAttribute('id) on undefined variable in case when we're using textarea.
I change this to finding tag of first element and then using it to next querySelector calls.
(I test this with inputs and textareas ans selects and it works ok)
Now it works with all kids of input (like it was) textarea and selects.
minification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to documentation we can change 'subwidget_form' to any build in or custom widget.
This option doesn't work because line 29-32 in querySelector hardcore looking for input field, and don't have any protection in case when it doesn't find it, so script throws error when it's trying getAttribute('id) on undefined variable in case when we're using textarea.
I change this to finding tag of first element (select, input , textarea) and then using it to next calls.
and i updated min. version.
(i made it because it doesn't work with textarea because of this script)