Deduplicate triangle-triangle intersection code #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Garrett-R wants to merge 2 commits into gradientspace:master from Garrett-R:master

Garrett-R commented Dec 2, 2018

I noticed there were 2 functions with nearly identical code. Two small differences:

the static version was slightly more performant having more ref usages, avoiding making copies. I took this one
the non-static one had a side-effect of setting the Type which I've maintained.

This is a pure refactor, API and functionality should be the same.

Garrett-R added 2 commits

December 2, 2018 04:51


          Deduplicate triangle-triangle intersection code

8902ea6


          Add to Projects using g3Sharp in README

3bde551

Author

Garrett-R commented Dec 2, 2018

I also added my project to the "Projects using g3Sharp" list, but let me know if you want me to drop that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet