Repository navigation
chore(deps): adopt fork template and tracing prerequisites - #717
Merged
Merged
Conversation
yuri-tceretian
added this pull request to stack #718
October 9, 2026 17:42
yuri-tceretian
force-pushed
the
yuri-tseretyan/adopt-fork-prerequisites
branch
from
October 14, 2026 14:45
2a87bfa to
a6884b7
Compare
yuri-tceretian
marked this pull request as ready for review
October 14, 2026 14:46
yuri-tceretian
force-pushed
the
yuri-tseretyan/adopt-fork-prerequisites
branch
from
October 14, 2026 14:58
a6884b7 to
49ccb1b
Compare
moustafab
approved these changes
Oct 14, 2026
moustafab
left a comment
moustafab
left a comment
Contributor
There was a problem hiding this comment.
One small question on the tracing change
|
|
||
| // instrument for tracing | ||
| client.Transport = tracing.Transport(client.Transport, "webhook") | ||
| client.Transport = tracing.Transport(client.Transport) |
Contributor
There was a problem hiding this comment.
Are we losing something with this?
Contributor
Author
There was a problem hiding this comment.
two side-effects:
- span will not contain integration type, which is ok because only webhook has tracing for now.
- the new tracing
otelhttpproduces more spans and more informative than the old one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Alertmanager fork to
7daeb08a46. This fork version adopts upstream Alertmanager v0.34.0 code:DeepCopyWithTemplate.Template.Data.The webhook integration now calls the 1-argument
tracing.Transport, which is what upstreamnotify.NewClientWithTracingdoes. Two tests pass the new route-labels and reason arguments.Behavior changes
notification_reasonandrouteLabels.This PR depends on #696. Merge it after #696.
Part of #694
Related to #712