[tempo-distributed] Configure ports #3544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xogoodnow
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
This matter was discussed in a previous PR (I made a mess with git history, sorry) If the ports section are there so folks would be able to change the ports, they must not be set statically but if the section is just informative, we can commit them all and just provide a link to the documentation. |
Signed-off-by: xogoodnow <[email protected]>
This reverts commit 74b128f. Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I see that almost all other services (except for metrics-generator) are static.
None of the service/port related configurations for gateway were actually dynamic.
Also changed the probe so the parameters could be configured
Cheers