[tempo-distributed] Fix Memcached StatefulSet volumeMounts formatting issue #3547
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue Signed-off-by: Bailey Jensen <[email protected]>
Signed-off-by: Bailey Jensen <[email protected]>
Signed-off-by: Bailey Jensen <[email protected]>
baileymjensen
force-pushed
the
fix-memcached-ss-fmt
branch
from
cbe98d2 to
560e0a9
Compare
baileymjensen
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In using this chart, I came across a formatting error. The conditional for disabling memcached-exporter does not wrap all of its possible settings. If you use volumeMounts and disable memcached-exporter, it still adds the volumeMounts and results in adding a second duplicate section to the memcached container config.
This change fixes that.
I also wonder if we should set the memcached-exporter extraVolumeMounts to be configured via:
.Values.memcachedExporter.extraVolumeMountsrather than the current.Values.memcached.extraVolumeMountsso that it is possible to mount different things into each container in the case you may need to rather than them both getting the same thing.