Refactor crypto_test.go to use Web Platform Tests #4979
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulnegz
requested review from
inancgumus and
ankur22
and removed request for
a team
|
|
inancgumus
approved these changes
Aug 5, 2025
inancgumus
requested changes
Aug 6, 2025
paulnegz
force-pushed
the
feature/refactor-crypto-test-to-wpt
branch
from
d5f6673 to
903d3cf
Compare
should be resolved now |
This PR aligns crypto_test.go with the Web Platform Tests (WPT) approach, following the successful pattern established in subtle_crypto_test.go. Changes: - Remove static test code from crypto_test.go - Integrate official WPT test files for core Crypto interface methods - Add getRandomValues.any.js and randomUUID.https.any.js from WPT - Create WebCryptoAPI__getRandomValues.any.js.patch for Float16Array handling - Move test setup functions to non-test file for better organization - Fix linting issues: context leak in getDurationContexts - Add testutils package with logger utilities for testing - Fix test timeouts in cloud output tests for stability This refactoring addresses issue grafana#4268 by: - Eliminating manual tracking of spec changes - Directly testing against WebPlatform test suite - Making deviations from standard explicit through patch files - Following successful pattern from grafana/xk6-webcrypto#87 All tests pass and changes maintain full backward compatibility while improving test coverage and maintainability.
paulnegz
force-pushed
the
feature/refactor-crypto-test-to-wpt
branch
from
1deabb3 to
437e3af
Compare
ankur22
reviewed
Sep 4, 2025
Comment on lines
+9
to
+11
| func NewLogger(t testing.TB) *Logger { | ||
| return &Logger{t: t} | ||
| } |
There was a problem hiding this comment.
What was the reason for adding this file?
ankur22
reviewed
Sep 4, 2025
| } | ||
| regDurationCtx, _ = context.WithDeadline(maxDurationCtx, startTime.Add(regularDuration)) //nolint:govet | ||
| regDurationCtx, regDurationCancel := context.WithDeadline(maxDurationCtx, startTime.Add(regularDuration)) | ||
| defer regDurationCancel() // Ensure the cancel function is called to avoid context leak |
There was a problem hiding this comment.
I'm not sure we want this. I would prefer a new PR which is separate from this PR if this is valid change. This PR should focus on the Web Platform Tests (WPT) approach of testing.
ankur22
reviewed
Sep 4, 2025
| stop: make(chan struct{}), | ||
| } | ||
| o.config.MetricPushInterval = types.NullDurationFrom(1 * time.Millisecond) | ||
| o.config.MetricPushInterval = types.NullDurationFrom(10 * time.Millisecond) |
There was a problem hiding this comment.
Can you revert the changes in this file too? I think they deserve a new PR if these a re valid changes, with more context.
ankur22
requested changes
Sep 4, 2025
|
@paulnegz we appreciate the work you have already put into this PR. Just to try to keep the PR section a bit tidier we're going to close this PR for now. Please do reopen when you have time to get back to working on it 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR aligns
crypto_test.gowith the Web Platform Tests (WPT) approach, following the successful pattern established insubtle_crypto_test.go. Specifically:Removed Static Tests:
crypto_test.goAdded WPT Integration:
getRandomValues.any.jsfor testing random value generationrandomUUID.https.any.jsfor UUID functionality testingRuntime Compatibility:
WebCryptoAPI__getRandomValues.any.js.patchfor Float16Array handlingWhy?
This refactoring addresses issue 4268:
Maintainability:
Standards Compliance:
Future-Proofing:
Implementation Details
The implementation follows the same successful approach used in grafana/xk6-webcrypto#90, ensuring consistency across the WebCrypto API testing suite.
All tests are passing, and the changes maintain full backward compatibility while improving test coverage and maintainability.
Closes 4268