-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Return ExecutionStatusMarkedAsFailed when exec.test.fail() is called #5423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AgnesToulet
wants to merge
5
commits into
master
Choose a base branch
from
marked-as-failed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
previously approved these changes
Nov 18, 2025
inancgumus
approved these changes
Nov 20, 2025
joanlopez
approved these changes
Nov 27, 2025
8 tasks
Contributor
Author
|
Thanks for the review but I actually have to split this into two PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHOULD ONLY BE MERGED AFTER https://github.com/grafana/k6-cloud-testcoordinator/pull/373
What?
This PR adds a new status to mark the end of a test:
ExecutionStatusMarkedAsFailedthat should be set whenexecution.test.fail()is called in the test.Why?
This will allow to return a better status in the Cloud. For now, the associated k6-cloud-testcoordinator PR uses this to return
cloudapi.RunStatusAbortedUser(as if the test was interrupted withabort) but we could work with the cloud team next to introduce a new status.Note, that an alternative to this if we only want to focus on the short-term solution would be to use
ExecutionStatusInterruptedinstead. Then, we wouldn't need the PR in k6-cloud-testcoordinator to returncloudapi.RunStatusAbortedUser(as it's already the case whenExecutionStatusInterruptedis received).Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Tests availabel here: https://github.com/grafana/k6-cloud-integration-tests/pull/137
Part of https://github.com/grafana/k6-cloud/issues/4022