Skip to content

Conversation

@grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Nov 18, 2025

What this PR does / why we need it:

This commit implements UpdateRates with a simple in-memory tracker. It does not replicate to Kafka currently because this produces a huge amount of volume that we need to replay on every restart. For now, since rate buckets are refilled very quickly, I propose we keep these in-memory without replication while we think about how to solve this.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner November 18, 2025 09:57
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-simple-rate-tracker branch from 03922cf to 86db298 Compare November 18, 2025 11:16
This commit implements UpdateRates with a simple in-memory tracker.
It does not replicate to Kafka currently because this produces
a huge amount of volume that we need to replay on every restart.
For now, since rate buckets are refilled very quickly, I propose
we keep these in-memory without replication while we think about
how to solve this.
@grobinson-grafana grobinson-grafana force-pushed the grobinson/add-simple-rate-tracker branch from 86db298 to 034576b Compare November 18, 2025 13:44
@grobinson-grafana grobinson-grafana merged commit 7a09c0d into main Nov 19, 2025
65 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/add-simple-rate-tracker branch November 19, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants