Skip to content

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Sep 18, 2025

What this PR does

The PR updates the anonymous usage statistics, so it reported the Mimir architecture (mode), the installation runs with.

Note, I've picked the key mode, and not "architecture" because the stats already report "arch" for the CPU architecture. I find it confusing. We already used "ingest-storage mode" in some context in the docs and in changelog, so I find it fitting.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]. If changelog entry is not needed, please add the changelog-not-needed label to the PR.
  • about-versioning.md updated with experimental features.

@narqo narqo requested a review from a team as a code owner September 18, 2025 17:54
@narqo narqo force-pushed the vldmr/usage-stats-mimir-arch branch from 51df779 to 65dc12b Compare September 18, 2025 17:54
Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good! I made a small suggestion.

CHANGELOG.md Outdated
* [ENHANCEMENT] Distributor: The metric `cortex_distributor_uncompressed_request_body_size_bytes` now differentiates by the handler serving the request. #12661
* [ENHANCEMENT] Query-frontend, querier: Add support for experimental `first_over_time` PromQL function. #12662
* [ENHANCEMENT] OTLP: native support for OpenTelemetry metric start time to Prometheus metric created timestamp conversion, instead of converting to QuietZeroNaNs introduced in #10238. The configuration parameter `-distributor.otel-start-time-quiet-zero` is therefore deprecated and will be removed. Now supports start time for exponential histograms. This is a major rewrite of the endpoint in upstream Prometheus and Mimir. #12652
* [ENHANCEMENT] Usage stats: report ingest-storage mode as part of usage statistics. #12753
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [ENHANCEMENT] Usage stats: report ingest-storage mode as part of usage statistics. #12753
* [ENHANCEMENT] Usage stats: Report ingest-storage mode as part of usage statistics. #12753

Signed-off-by: Vladimir Varankin <[email protected]>
@narqo narqo force-pushed the vldmr/usage-stats-mimir-arch branch from 65dc12b to 22ea786 Compare September 29, 2025 12:34
@narqo narqo enabled auto-merge (squash) September 29, 2025 12:35
@narqo narqo merged commit a58384a into main Sep 29, 2025
37 checks passed
@narqo narqo deleted the vldmr/usage-stats-mimir-arch branch September 29, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants