Replace the internal reactivelimiter with a wrapped Failsafe-go limiter #12773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhalterman
force-pushed
the
failsafe-go-reactive-limiter
branch
4 times, most recently
from
befab9c to
47a27ad
Compare
jhalterman
changed the title
jhalterman
force-pushed
the
failsafe-go-reactive-limiter
branch
3 times, most recently
from
b9c84a1 to
189a2e9
Compare
jhalterman
requested review from
stevesg,
a team and
tacole02
as code owners
jhalterman
force-pushed
the
failsafe-go-reactive-limiter
branch
from
189a2e9 to
2532375
Compare
tacole02
approved these changes
Sep 26, 2025
jhalterman
force-pushed
the
failsafe-go-reactive-limiter
branch
from
8bd5925 to
37de024
Compare
|
Overall the change looks good to me. |
jhalterman
added a commit
that referenced
this pull request
Oct 2, 2025
…er (#12773) <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Rebase your PR if it gets out of sync with main --> #### What this PR does This PR replaces Mimir's internal reactive limiter with a wrapper around Failsafe-go's [adaptive limiter](https://failsafe-go.dev/adaptive-limiter/), which has moved ahead in terms of maturity. It also uses Failsafe-go's [Prioritizer](https://failsafe-go.dev/execution-prioritization/). #### Which issue(s) this PR fixes or relates to Fixes #<issue number> #### Checklist - [ ] Tests updated. - [x] Documentation added. - [x] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR replaces Mimir's internal reactive limiter with a wrapper around Failsafe-go's adaptive limiter, which has moved ahead in terms of maturity. It also uses Failsafe-go's Prioritizer.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.