Test pruning toggles AST optimization pass with query planner #12784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenador
changed the base branch from
main
to
zenador/fix-ast-opt-pass-step-invar-expr
4 tasks
charleskorn
reviewed
Sep 23, 2025
| require.NoError(t, testutil.GatherAndCompare(g, strings.NewReader(expectedMetrics), metricNameTotal, metricNameChanged)) | ||
| } | ||
|
|
||
| func TestPruneTogglesWithQueryPlan(t *testing.T) { |
There was a problem hiding this comment.
Rather than introducing a new unit test for this, what if we changed the existing unit tests to follow this structure?
(and not just this optimisation pass, but all of them)
There was a problem hiding this comment.
Didn't make this change for reordering histograms and propagating matchers as those are currently frontend middlewares, not optimization passes, so can't be added to the query plan.
zenador
force-pushed
the
zenador/test-ast-opt-pass-with-query-planner
branch
from
f85c241 to
d88cfef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Make our unit testing of the pruning toggles more thorough by testing it as part of the query planner.
Just pruning toggles for now as the other new ones are applied as frontend middlewares.
Which issue(s) this PR fixes or relates to
Follow up to #12783 , waiting for that to be merged first.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.Only updates tests, not user facing.