Add config option to exclude 'le' from series sharding to ingesters / partitions #12815
+202
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seizethedave
approved these changes
Sep 25, 2025
| "validation.max-cost-attribution-cardinality": 2000, | ||
| "validation.cost-attribution-cooldown": 0, | ||
| "ruler.evaluation-delay-duration": 60000000000, | ||
| "ruler.evaluation-consistency-max-delay": 0, |
There was a problem hiding this comment.
Know where this diff came from?
| return | ||
| } | ||
|
|
||
| h = HashAdd32(h, l.Name) |
There was a problem hiding this comment.
I suppose it wouldn't improve anything to include the label name in the hash as all series in foo_seconds_histogram have that label, correct?
There was a problem hiding this comment.
I don't think adding just the label name makes any practical difference.
… partitions Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
shard-without-le-label
branch
from
4bd5b2d to
32cf5f2
Compare
|
Tested in a dev environment and doesn't solve the issue we're experiencing, so switch it back to draft while I keep investigating it. |
tacole02
approved these changes
Sep 26, 2025
| * [ENHANCEMENT] Ingester: Improved the performance of active series custom trackers matchers. #12663 | ||
| * [ENHANCEMENT] Compactor: Log sizes of downloaded and uploaded blocks. #12656 | ||
| * [ENHANCEMENT] Ingester: Add `cortex_ingest_storage_reader_receive_and_consume_delay_seconds` metric tracking the time between when a write request is received in the distributor and its content is ingested in ingesters, when the ingest storage is enabled. #12751 | ||
| * [ENHANCEMENT] Distributor: Add experimental configuration option `-distributor.sharding.exclude-classic-histogram-bucket-label` to compute the series hash – used for sharding – excluding the 'le' label. When this configuration option is set to true, all buckets of a classic histogram metric are stored in the same shard. #12815 |
There was a problem hiding this comment.
Suggested change
| * [ENHANCEMENT] Distributor: Add experimental configuration option `-distributor.sharding.exclude-classic-histogram-bucket-label` to compute the series hash – used for sharding – excluding the 'le' label. When this configuration option is set to true, all buckets of a classic histogram metric are stored in the same shard. #12815 | |
| * [ENHANCEMENT] Distributor: Add anexperimental configuration option, `-distributor.sharding.exclude-classic-histogram-bucket-label`, to compute the series hash, used for sharding, excluding the 'le' label. When you set this configuration option to true, all buckets of a classic histogram metric are stored in the same shard. #12815 |
| "kind": "field", | ||
| "name": "exclude_classic_histogram_bucket_label", | ||
| "required": false, | ||
| "desc": "When set to true, the distributor computes the series hash – used for sharding – excluding the 'le' label. This means that, when this configuration option is set to true, all buckets of a classic histogram metric are stored in the same shard. This configuration option should be set for distributors, rulers and ingesters.", |
There was a problem hiding this comment.
Suggested change
| "desc": "When set to true, the distributor computes the series hash – used for sharding – excluding the 'le' label. This means that, when this configuration option is set to true, all buckets of a classic histogram metric are stored in the same shard. This configuration option should be set for distributors, rulers and ingesters.", | |
| "desc": "When set to true, the distributor computes the series hash, used for sharding, excluding the 'le' label. This means that when you set this configuration option to true, all buckets of a classic histogram metric are stored in the same shard. Set this configuration option for distributors, rulers, and ingesters.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In this PR I propose to add an experimental config option to exclude the
lewhen compute the series hash, used for sharding to ingesters / partitions.This is to confirm whether the flakyness we see when querying the most recent data from classic histograms is due to inconsistent bucket values when the ingest storage is used. We see the similar issue in classic architecture, and apparently the issue disappear if this same exact change is done in Alloy remote storage sharding, but it still persist in the ingest storage architecture. My theory is that it's because Mimir suffers the same issue too, so I would like to experiment removing the
lefrom classic histograms sharding.No measurable perf impact:
Which issue(s) this PR fixes or relates to
Ref: https://github.com/grafana/mimir-squad/issues/3263
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.