-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade golangci-lint to v1.52.2 #5067
Conversation
There are a bunch of places where it is clearer to retain the current style.
I'm pushing a new build image, and will update the PR as you request :) |
Signed-off-by: Arve Knudsen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I <3 linters
Though, in the future I might recommend splitting up into smaller PRs, so the reviewing is easier and there's less risk of hitting merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @aknuds1 can you merge the PR once you've done publishing the new build image? I have another big refactoring PR lining up and I don't want to deal with such conflicts. Thanks!
@pracucci I will fix the conflicts and merge (build image is already updated). |
…lint-upgrade Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1 About this linter error:
You can just make the linter happy. I will take care of removing that dead code in a follow up PR. |
Signed-off-by: Arve Knudsen <[email protected]>
What this PR does
This PR upgrades
golangci-lint
to v1.52.2 and fixes all new linting warnings, primarily from the upgraded version ofrevive
.Some warnings are false positives (see mgechev/revive#386) and have been ignored. The new
if-return
rule fromrevive
enabled by default seemed unnecessary and has been disabled.ℹ️ This PR will require a maintainer with permission to push the build image to Docker Hub to build and push the build image to Docker Hub and then update the image tag in the
Makefile
before merging (see these instructions).Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]