fix: Redact password field in RemoteInfo type #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem
commented
May 26, 2025
| type T RemoteInfo | ||
| var tmp T = T(ri) | ||
|
|
||
| tmp.Password = `<redacted>` |
There was a problem hiding this comment.
I'm probably messing up something by using redacted. It should be <encrypted>, or at least I think the frontend might be expecting that.
There was a problem hiding this comment.
I changed this to <encrypted> because that is what the API is using in some cases.
<encrypted> makes sense in that case because the API is encrypting these tokens in the database. <redacted> would be more appropriate in the general case, but we need to confirm we can make that change without breaking the frontend.
mem
force-pushed
the
mem/redact-password-in-remote-info
branch
from
99ff765 to
8ce00f8
Compare
The-9880
previously approved these changes
Jun 2, 2025
When logging using zerolog or when marshaling to JSON, we don't really have a need to log the actual password and instead we have a requirement not to do so. Add that behavior by implementing a couple of interfaces, one for zerolog and one for the JSON marshaller (stdlib). Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
mem/redact-password-in-remote-info
branch
from
8ce00f8 to
8e85fe4
Compare
|
Implementation-wise, this looks fine to me. I'll confirm with FE how this value is being used before approving so that we're sure it doesn't break some assumption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging using zerolog or when marshaling to JSON, we don't really have a need to log the actual password and instead we have a requirement not to do so.
Add that behavior by implementing a couple of interfaces, one for zerolog and one for the JSON marshaller (stdlib).