fix: Replace zerolog.Nop() with conditional logger #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem
force-pushed
the
mem/add-logger-and-k6-testhelper
branch
from
2914566 to
dc95f38
Compare
We have a few places where we use zerolog.Nop() in tests, which is fine if we want to cut down the noise, but it's very difficult to use if there are failures. Change the direct calls to zerolog.Nop() to testhelper.Logger(t), which will create a zerolog instance configured to filter out everything below the error level. If the user passes the verbose flag to `go test`, when it switches to using debug level. Also add another helper, K6Path(*testing.T), which builds the path to the k6 binary used in tests, and fails if that doesn't exist, to prevent harder to debug errors down the test. Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
mem/add-logger-and-k6-testhelper
branch
from
dc95f38 to
fc0fc01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few places where we use zerolog.Nop() in tests, which is fine if we want to cut down the noise, but it's very difficult to use if there are failures.
Change the direct calls to zerolog.Nop() to testhelper.Logger(t), which will create a zerolog instance configured to filter out everything below the error level. If the user passes the verbose flag to
go test, when it switches to using debug level.Also add another helper, K6Path(*testing.T), which builds the path to the k6 binary used in tests, and fails if that doesn't exist, to prevent harder to debug errors down the test.