fix: Don't stop publisher if we hit Loki's stream limit #1356
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we are stopping the publisher if we hit Loki's stream limit, as we consider that to be a fatal error. The actual observed behavior is that Loki will accept *some* data and it will reject some. Even more confusing, it seems like the stream was rejected (presumably the one that is going over the limit), might be accepted at a later point in time. After this change the behavior is that whatever data was rejected is dropped, and the rest of the publisher keeps working as if nothing had happened. We will have to observe the actual behavior to decide if this makes sense or not. This is related to #1355. Signed-off-by: Marcelo E. Magallon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are stopping the publisher if we hit Loki's stream limit, as we consider that to be a fatal error. The actual observed behavior is that Loki will accept some data and it will reject some. Even more confusing, it seems like the stream was rejected (presumably the one that is going over the limit), might be accepted at a later point in time.
After this change the behavior is that whatever data was rejected is dropped, and the rest of the publisher keeps working as if nothing had happened. We will have to observe the actual behavior to decide if this makes sense or not.
This is related to #1355.