chore: remove go-kit/log from the agent #1435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0ugal
force-pushed
the
rm-go-kit
branch
3 times, most recently
from
67a67b6 to
80ce876
Compare
d0ugal
force-pushed
the
rm-go-kit
branch
2 times, most recently
from
723dad8 to
cd3de5d
Compare
d0ugal
force-pushed
the
rm-go-kit
branch
3 times, most recently
from
dc8f489 to
b3192e7
Compare
d0ugal
force-pushed
the
rm-go-kit
branch
4 times, most recently
from
c0bfb5b to
8482a81
Compare
- Change '// nolint' to '//nolint' in dns.go and utils.go - Resolves nolintlint linter errors
- Revert test changes that were causing compilation errors - The test failures are due to log format change from text to JSON - This is expected behavior after refactoring to use slog with zerolog backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-kit was removed from BBE, they migrated to slog. We primarily use zerolog. This means that we have been converting
zerologtogo-kittoslogin several places. This would be much simpler if we removed go-kit, which currently only acts as a intermediate loggger for code that was previously designed to work with blackbox exporter logging setup.The goal with this PR is to simplify our logging setup and use only zerolog with conversions to slog when needed.