Feat/pull cost attribution labels from tenant #1544
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⚠️ This is based upon the feedback from @ka3de in #1655⚠️ Update the protobuf definition to have cost attribution labels associated with tenants instead of directly on checks. This allows the api to pick up the changes and test out propogated cal's from the api to checks.
Following a similar path as limits to pull cost attribution labels for tenants. Adds a new internal library `cals/tenant.go` that provides an interface that wraps the `TenantProvider` client. Updates all of the wiring from Updated => Scraper to pass along the new cal client. Starts the process of using the library in `scraper.go`, which right now finds the cost attribution labels for a specific tenant. Returns an empty slice if nothing is found. This will be dependant upon the API changes being released to get cost attribution labels defined at the tenant level.
Add a `testCalTenants` interface to mock out the cost attribution label servce. This fixes the tests that were failing on the latest commits to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a similar path as limits to pull cost attribution labels for
tenants. Adds a new internal library
cals/tenant.gothat provides aninterface that wraps the
TenantProviderclient. Updates all of thewiring from Updated => Scraper to pass along the new cal client.
Starts the process of using the library in
scraper.go, which right nowfinds the cost attribution labels for a specific tenant. Returns an
empty slice if nothing is found.
This will be dependent upon the API changes being released to get cost
attribution labels defined at the tenant level.