Set default limits to oauth proxy #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <[email protected]>
rubenvp8510
force-pushed
the
set_recources_tempo_frontend
branch
from
0060b51 to
e26298c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
+ Coverage 58.60% 58.61% +0.01%
==========================================
Files 113 113
Lines 10160 10168 +8
==========================================
+ Hits 5954 5960 +6
- Misses 3900 3902 +2
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -90,13 +90,16 @@ func BuildQueryFrontend(params manifestutils.Params) ([]client.Object, error) { | |||
| jaegerUIAuthentication := tempo.Spec.Template.QueryFrontend.JaegerQuery.Authentication | |||
|
|
|||
| if jaegerUIAuthentication != nil && jaegerUIAuthentication.Enabled { | |||
| defaultOauthProxyResources := manifestutils.Resources(tempo, manifestutils.QueryFrontendComponentName, tempo.Spec.Template.QueryFrontend.Replicas) | |||
There was a problem hiding this comment.
I think it should take the resources from jaeger-frontend-proxy, not from manifestutils.QueryFrontendComponentName, or am I reading it wrong?
There was a problem hiding this comment.
Oh true! a mistake! good catch thanks
Signed-off-by: Ruben Vargas <[email protected]>
andreasgerstmayr
approved these changes
Feb 7, 2025
pavolloffay
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.