Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openshift sertvice annotation when gateway is disabled (monolithic) #975

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented Jul 9, 2024

This is the monolithic version

Depends on #977

@rubenvp8510 rubenvp8510 requested a review from pavolloffay July 9, 2024 07:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.

Project coverage is 73.01%. Comparing base (89d1bb7) to head (522a462).

Files Patch % Lines
internal/manifests/monolithic/util.go 33.33% 14 Missing and 2 partials ⚠️
internal/manifests/monolithic/build.go 0.00% 11 Missing and 1 partial ⚠️
internal/manifests/monolithic/services.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
- Coverage   73.23%   73.01%   -0.23%     
==========================================
  Files         105      106       +1     
  Lines        6512     6547      +35     
==========================================
+ Hits         4769     4780      +11     
- Misses       1451     1472      +21     
- Partials      292      295       +3     
Flag Coverage Δ
unittests 73.01% <31.81%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.chloggen/tls_cert_serv_mono.yaml Outdated Show resolved Hide resolved
.chloggen/tls_cert_serv_mono.yaml Show resolved Hide resolved
@rubenvp8510 rubenvp8510 force-pushed the tls_cert_serv_mono branch 5 times, most recently from ae41201 to 522a462 Compare July 12, 2024 13:37
@rubenvp8510 rubenvp8510 merged commit 7d2f057 into grafana:main Jul 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants