Fetch blobs from EL via engine_getBlobsV1:
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangleang
reviewed
Jan 8, 2025
Comment on lines
+529
to
534
| self.request_blobs_from_execution_engine( | ||
| pending_block.block.clone_arc(), | ||
| missing_blob_indices.clone(), | ||
| ); | ||
|
|
||
| let blob_ids = missing_blob_indices |
There was a problem hiding this comment.
so in the case if a node missed some blobs, it fetches those blobs from local EL while at the same time, request from peer through RPC as well. why don't implement fallback instead?
There was a problem hiding this comment.
I believe the idea here is to have blobs available as soon as possible so that block could be processed with minimal delay
SifraiTeam
force-pushed
the
feature/get-blobs-from-el
branch
from
90c710d to
4c39571
Compare
- Add 'engine_exchangeCapabilities' request to be able to tell if EL serves blobs. - Fetch capabilities on startup and on every epoch start. - Rewrite `eth1_api::Endpoints` not to use mutexes.
SifraiTeam
force-pushed
the
feature/get-blobs-from-el
branch
from
4c39571 to
047520e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth1_api::Endpointsnot to use mutexes.