Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve dependency issues when no Magento packages are used #2487

Merged
merged 16 commits into from
Jan 23, 2025
Merged

Solve dependency issues when no Magento packages are used #2487

merged 16 commits into from
Jan 23, 2025
+4,979 −5,575

Conversation

paales
Copy link
Member

@paales paales commented Jan 23, 2025

No description provided.

paales added 13 commits January 23, 2025 10:53
@paales
When a dependency is optional or has peerDependenciesMeta set to opti…
8b25322 
…onal, make sure it doesn't crash when it is not found when calling resolveDependenciesSync
@paales
Solve issue where withGraphCommerce had a hard dependency on Magento …
30b7356 
…specific configurations
@paales
Remove redirects for /product/$type/[url] routes, those haven't bee…
2c79a4c 
…n used for years anymore.
@paales
Add compiled js
494a6a5
@paales
Migrated @graphcommerce/next-config package to "type": "module"
5ffa0ee
@paales
Added missing WebWorker tsconfig for magento-open-source example
af04d45
@paales
Updated generated config, do not disable eslint for the file, as that…
f6c26bf 
… is not necessary anymore.
@paales
Migrated @graphcommerce/hygraph-cli package to "type": "module"
c25bb10
@paales
Make sure the cli package can be properly resolved with resolveDepend…
446ee0c 
…enciesSync
@paales
Remove dependencies from @graphcommerce/googletagmanager and `@grap…
cbf92b8 
…hcommerce/googleanalytics` on Magento packages and make the datalayer optional
@paales
Forward <Asset unoptimized /> component to <Image />
2085f0b
@paales
Prepare the RichTex for embed and code-block
cf9eafb
@paales
Remove dependency on Magento for @graphcommerec/react-hook-form
935f8f9
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 4e5d525

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 83 packages
Name Type
@graphcommerce/react-hook-form Patch
@graphcommerce/next-config Patch
@graphcommerce/hygraph-ui Patch
@graphcommerce/hygraph-cli Patch
@graphcommerce/misc Patch
@graphcommerce/googletagmanager Patch
@graphcommerce/googleanalytics Patch
@graphcommerce/magento-graphcms Patch
@graphcommerce/magento-open-source Patch
@graphcommerce/hygraph-dynamic-rows-ui Patch
@graphcommerce/framer-scroller-example Patch
@graphcommerce/docs Patch
@graphcommerce/browserslist-config-pwa Patch
@graphcommerce/changeset-changelog Patch
@graphcommerce/eslint-config-pwa Patch
@graphcommerce/graphql-codegen-markdown-docs Patch
@graphcommerce/graphql-codegen-near-operation-file Patch
@graphcommerce/graphql-codegen-relay-optimizer-plugin Patch
@graphcommerce/prettier-config-pwa Patch
@graphcommerce/typescript-config-pwa Patch
@graphcommerce/address-fields-nl Patch
@graphcommerce/algolia-categories Patch
@graphcommerce/algolia-insights Patch
@graphcommerce/algolia-personalization Patch
@graphcommerce/algolia-products Patch
@graphcommerce/algolia-recommend Patch
@graphcommerce/algolia-search Patch
@graphcommerce/cli Patch
@graphcommerce/demo-magento-graphcommerce Patch
@graphcommerce/ecommerce-ui Patch
@graphcommerce/framer-next-pages Patch
@graphcommerce/framer-scroller Patch
@graphcommerce/framer-utils Patch
@graphcommerce/google-datalayer Patch
@graphcommerce/google-playstore Patch
@graphcommerce/googlerecaptcha Patch
@graphcommerce/graphcms-ui Patch
@graphcommerce/graphql-mesh Patch
@graphcommerce/graphql Patch
@graphcommerce/hygraph-dynamic-rows Patch
@graphcommerce/image Patch
@graphcommerce/lingui-next Patch
@graphcommerce/magento-cart-billing-address Patch
@graphcommerce/magento-cart-checkout Patch
@graphcommerce/magento-cart-coupon Patch
@graphcommerce/magento-cart-email Patch
@graphcommerce/magento-cart-items Patch
@graphcommerce/magento-cart-payment-method Patch
@graphcommerce/magento-cart-pickup Patch
@graphcommerce/magento-cart-shipping-address Patch
@graphcommerce/magento-cart-shipping-method Patch
@graphcommerce/magento-cart Patch
@graphcommerce/magento-category Patch
@graphcommerce/magento-cms Patch
@graphcommerce/magento-compare Patch
@graphcommerce/magento-customer Patch
@graphcommerce/magento-graphql-rest Patch
@graphcommerce/magento-graphql Patch
@graphcommerce/magento-newsletter Patch
@graphcommerce/magento-payment-adyen Patch
@graphcommerce/magento-payment-braintree Patch
@graphcommerce/magento-payment-included Patch
@graphcommerce/magento-payment-klarna Patch
@graphcommerce/magento-payment-multisafepay Patch
@graphcommerce/magento-payment-paypal Patch
@graphcommerce/magento-product-bundle Patch
@graphcommerce/magento-product-configurable Patch
@graphcommerce/magento-product-downloadable Patch
@graphcommerce/magento-product-grouped Patch
@graphcommerce/magento-product-simple Patch
@graphcommerce/magento-product-virtual Patch
@graphcommerce/magento-product Patch
@graphcommerce/magento-recently-viewed-products Patch
@graphcommerce/magento-review Patch
@graphcommerce/magento-search-overlay Patch
@graphcommerce/magento-search Patch
@graphcommerce/magento-store Patch
@graphcommerce/magento-wishlist Patch
@graphcommerce/mollie-magento-payment Patch
@graphcommerce/next-ui Patch
@graphcommerce/service-worker Patch
@graphcommerce/framer-next-pages-example Patch
@graphcommerce/image-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graphcommerce ✅ Ready (Inspect) Visit Preview Jan 23, 2025 0:57am
graphcommerce-hygraph-dynamic-rows-ui ✅ Ready (Inspect) Visit Preview Jan 23, 2025 0:57am
graphcommerce-open-source ✅ Ready (Inspect) Visit Preview Jan 23, 2025 0:57am
magento-2.4.7 ❌ Failed (Inspect) Jan 23, 2025 0:57am

@paales paales changed the title Fix/no magento Solve dependency issues when no Magento packages are used Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

Page Size old Size new Size diff First load old First load new First load diff
/ 0.7kB 0.7kB 310kB 311.0kB +1kB⚠️
/[...url] 2.2kB 2.2kB 337kB 338.0kB +1kB⚠️
ƒ /c/[...url] 2.2kB 2.2kB 337kB 338.0kB +1kB⚠️
/checkout 10.2kB 10.3kB 0.1kB 299kB 299.0kB
/service/[[...url]] 1.5kB 1.5kB 287kB 288.0kB +1kB⚠️

@paales paales merged commit c513f58 into canary Jan 23, 2025
6 of 7 checks passed
@paales paales deleted the fix/no-magento branch January 23, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@paales