-
Notifications
You must be signed in to change notification settings - Fork 11
Switch to pyproject.toml #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
74956fe
eb4aea1
f700477
222508f
44b1513
c55f2dc
8419461
362cecf
fe294e6
2f5ad95
b16c72a
7d5dfb8
161b245
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
* | ||
!requirements*.txt | ||
!requirements-dev.txt |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ __pycache__ | |
.venv | ||
.venvs | ||
.vscode | ||
unit_scaling/_version.py | ||
|
||
/build | ||
/dist | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# Configuration inspired by official pypa example: | ||
# https://github.com/pypa/sampleproject/blob/main/pyproject.toml | ||
|
||
[build-system] | ||
requires = ["setuptools>=68.2.2", "setuptools-scm"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "unit-scaling" | ||
description = "A library for unit scaling in PyTorch, based on the paper 'u-muP: The Unit-Scaled Maximal Update Parametrization.'" | ||
readme = "README.md" | ||
authors = [ | ||
{ name = "Charlie Blake", email = "[email protected]" }, | ||
{ name = "Douglas Orr", email = "[email protected]" }, | ||
] | ||
requires-python = ">=3.9" | ||
classifiers = [ | ||
"Development Status :: 4 - Beta", | ||
"Intended Audience :: Developers", | ||
"Intended Audience :: Science/Research", | ||
"License :: OSI Approved :: Apache Software License", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
"Programming Language :: Python :: 3.13", | ||
"Programming Language :: Python :: 3.14", | ||
"Topic :: Scientific/Engineering :: Artificial Intelligence", | ||
] | ||
dependencies = [ | ||
"datasets", | ||
"docstring-parser", | ||
"einops", | ||
"numpy<2.0.0", | ||
"seaborn", | ||
"tabulate", | ||
"torch>=2.2", | ||
] | ||
dynamic = ["version"] | ||
|
||
[project.urls] | ||
"Homepage" = "https://github.com/graphcore-research/unit-scaling/#readme" | ||
"Bug Reports" = "https://github.com/graphcore-research/unit-scaling/issues" | ||
"Source" = "https://github.com/graphcore-research/unit-scaling/" | ||
|
||
[project.optional-dependencies] | ||
dev = ["check-manifest"] | ||
test = ["pytest"] | ||
|
||
[tool.setuptools] | ||
packages = ["unit_scaling", "unit_scaling.core", "unit_scaling.transforms"] | ||
|
||
[tool.setuptools.dynamic] | ||
version = {attr = "unit_scaling._version.__version__"} | ||
|
||
[tool.setuptools_scm] | ||
version_file = "unit_scaling/_version.py" |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
[options] | ||
packages = | ||
unit_scaling | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess most of this file could go into pyproject.toml, but perhaps still not flake8. That said, unless you can delete this file entirely, I don't see much benefit in moving. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, that was my thinking entirely - looking at Paul's stuff it seemed like he could move everything except flake8, which made me not bother. Though switching to better tools should fix this 🙃 |
||
[mypy] | ||
pretty = true | ||
show_error_codes = true | ||
|
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why install
--user
in a Dockerfile - I usually assume everything can go system-wide within the image..?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At one point I was having some nasty ownership issues so I shifted to this, though I'm not sure if this was actually the fix in the end. Docker ownership stuff scares me, so this does make me feel a little safer even if it's not necessary 🤷 unless you think this could cause issues...