parser: Avoid reading after the end of shunting yard stack#209
Open
sin-ack wants to merge 1 commit intographitemaster:mainfrom
Open
parser: Avoid reading after the end of shunting yard stack#209sin-ack wants to merge 1 commit intographitemaster:mainfrom
sin-ack wants to merge 1 commit intographitemaster:mainfrom
Conversation
We would previously do this: - Erase items from the buffer - Read the items we just erased This is a mistake because the vector might have resized itself after the erase call. This would cause assertion errors with the GNU STL. We now instead read the offsets we want to read from before performing the erase. There may be other occurrences of this, but I've only hit these cases when compiling Xonotic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would previously do this:
This is a mistake because the vector might have resized itself after the erase call. This would cause assertion errors with the GNU STL. We now instead read the offsets we want to read from before performing the erase.
There may be other occurrences of this, but I've only hit these cases when compiling Xonotic.