Issuance baseline #1243
Draft
Issuance baseline #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add NatSpec documentation (@title, @author, @notice, @param) - Add solhint-disable directives with TODO comments for future fixes - Minor code formatting changes to address lint rules All packages now pass pnpm lint with no reported issues. Verified with scripts/compare-repo-contract-bytecode-excluding-metadata.mjs: only mock contracts have functional bytecode changes.
- Move 36 duplicate interface files from contracts and token-distribution to interfaces package - Update all import statements across contracts, token-distribution, horizon, and subgraph-service to use @graphprotocol/interfaces - Delete duplicate interface files from source packages - Fix pragma versions for compatibility across compiler configurations - Add @graphprotocol/interfaces dependency to token-distribution All builds and tests passing.
- Dual-version interfaces: ^0.7.x || ^0.8.0 (max compatibility) - V0.8-only interfaces: ^0.8.22 (modern features support) Interfaces should allow wider compiler version ranges for external consumer compatibility, while implementations use exact versions for predictable compilation. Dual-version files use ^0.8.0 since they can't leverage v0.8 features anyway. V0.8-only files use ^0.8.22 for custom errors and named mappings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add explanation of open-ended pragma ranges for interface compatibility and document available TypeScript type generation formats.
- Rename interface parameters to avoid conflicts with getter functions - Add parameter references in mock contracts to silence unused warnings - Configure hardhat-ignore-warnings for contracts/test package
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR establishes a baseline for issuance-related contracts and interfaces, introducing a new issuance package with allocator and eligibility functionality while updating interface pragma versions for better compiler compatibility.
Key changes:
- Introduces new
@graphprotocol/issuancepackage with allocator and eligibility contracts - Updates interface pragma statements from exact versions to open-ended ranges (e.g.,
^0.8.22) - Adds solhint disable comments across multiple packages to defer linting issues
- Removes local interface files in favor of centralized
@graphprotocol/interfacesimports
Reviewed Changes
Copilot reviewed 289 out of 300 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/issuance/** | New issuance package with allocator/eligibility contracts and test infrastructure |
| packages/interfaces/contracts/** | Updated pragma versions to use caret ranges for better compatibility |
| packages/*/contracts/** | Added solhint disable comments and migrated to centralized interface imports |
| packages/horizon/contracts/** | Updated IGraphToken imports from contracts to interfaces package |
| packages/contracts/test/** | Added SubgraphService rewards tests and hardhat configuration updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Issuance baseline
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
+ Coverage 82.84% 83.67% +0.83%
==========================================
Files 47 43 -4
Lines 2093 2120 +27
Branches 620 633 +13
==========================================
+ Hits 1734 1774 +40
+ Misses 359 346 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.