-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Substreams docs and to New Chain Integrations #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nks need to be fixed, but need to identify source.
idalithb
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Giuliano-1 This is terrific! Thank you for adding these.
Some things to note:
- You should be able to view all the changes I've merged into this branch prior to this review (alongside general descriptions with each commit)
- I will make a separate PR to edit the sps FAQ page, but for now we should be able to merge this after your review.
Thank you 😄
# Conflicts: # website/pages/ar/subgraphs/cookbook/substreams-powered-subgraphs.mdx # website/pages/en/subgraphs/cookbook/substreams-powered-subgraphs.mdx
benface
reviewed
Jan 24, 2025
Co-authored-by: Benoît Rouleau <[email protected]>
idalithb
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks good to me! Pending comments can get worked out on another PR
Giuliano-1
added a commit
that referenced
this pull request
Jan 27, 2025
This reverts commit 48598b0.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to the Substreams directory adding the required docs requested by different individuals. Reviews to be done here. And made very minimal updates to New Chain Integrations.