node: pause subgraphs before reassigning in graphman #6160
+41
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
requested changes
Sep 15, 2025
Comment on lines
+26
to
+29
| println!( | ||
| "Waiting {}s to make sure pausing was processed ...", | ||
| delay.as_secs() | ||
| ); |
There was a problem hiding this comment.
The delay is not actually used, i think what you meant to do is to call sleep() here too with the delay
Comment on lines
+44
to
48
| primary_pool.clone(), | ||
| notification_sender.clone(), | ||
| &deployment, | ||
| node, | ||
| curr_node, |
There was a problem hiding this comment.
minor nitpick: if the pause::run succeeds and actual reassign fails the resume will never run and the subgraph would be paused unintentionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reassigning subgraph and not pausing, it gives the below error and creates a race condition.
This PR solves the issue by pausing subgraphs and waits before reassigning subgraphs.