fix: issue #65: type of ResolveInfo.RootValue should be interface{}#608
Open
chirino wants to merge 1 commit intographql-go:masterfrom
Open
fix: issue #65: type of ResolveInfo.RootValue should be interface{}#608chirino wants to merge 1 commit intographql-go:masterfrom
chirino wants to merge 1 commit intographql-go:masterfrom
Conversation
Member
|
@chirino thanks for filing a PR — I don't think we should be changing this end-user type: An alternative strategy would be to have a small wrapper around your resolvers that consolidates |
Author
|
To avoid the breaking change we could Introduce a new field and deprecate RootValue and ask folks to stop using RootValue. |
…rams.Root that is an interface{}
Author
|
@chris-ramon what about this new version? |
Contributor
|
RootValue is part of the spec, I don't think deprecating it is a good idea. That said, will changing it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes type of ResolveInfo.RootValue ot be interface{}
I would like to set the RootObject to a struct pointer that my resolvers would rather deal with.