Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test rabbit #6440

Closed
wants to merge 1 commit into from
Closed

test rabbit #6440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/services/usage/.env.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ KAFKA_TOPIC="usage_reports_v2"
PORT=4001
RATE_LIMIT_ENDPOINT="http://localhost:4012"
OPENTELEMETRY_COLLECTOR_ENDPOINT="<sync>"
TEST_NEW_VAR=1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update README.md with TEST_NEW_VAR documentation

The new environment variable TEST_NEW_VAR needs to be documented in the service's README.md configuration table. Since this appears to be a test-only variable, it doesn't require updates to deployment IaC or Docker Compose files.

  • Add TEST_NEW_VAR to the configuration table in packages/services/usage/README.md
🔗 Analysis chain

Verify related configuration files are updated.

When adding new environment variables to .env.template, several related files need to be updated:

  1. Update the service's README.md with documentation about the new variable
  2. Update Docker Compose files with default values
  3. Update IaC deployment code in the deployment directory

Let's verify these changes:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if related configuration files are updated with the new environment variable

echo "Checking README.md..."
fd README.md packages/services/usage -x rg -l "TEST_NEW_VAR"

echo "Checking Docker Compose files..."
fd docker-compose packages/services/usage -x rg -l "TEST_NEW_VAR"

echo "Checking deployment IaC files..."
fd . deployment -t f -x rg -l "TEST_NEW_VAR"

Length of output: 374

Script:

#!/bin/bash
# First, check if these files exist
echo "Checking for README.md..."
fd README.md packages/services/usage --type f

echo -e "\nChecking for docker-compose files..."
fd docker-compose packages/services/usage --type f

echo -e "\nChecking for deployment directory..."
fd . deployment --type d --max-depth 1

# If deployment dir exists, check its structure
echo -e "\nChecking deployment directory structure (if exists)..."
fd . deployment --type f -x echo {}

Length of output: 3150

Script:

#!/bin/bash
echo "Checking README.md content..."
cat packages/services/usage/README.md

echo -e "\nChecking for root level docker-compose files..."
fd docker-compose --max-depth 2 --type f

echo -e "\nChecking usage service deployment configuration..."
cat deployment/services/usage.ts

Length of output: 10705

Loading