Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add federation-link-util library #6452
feature: add federation-link-util library #6452
Changes from all commits
379ba8e
51b4940
5cc162e
3f4af5c
998f5a4
828e16b
e345a13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If see that this code (and some other in the lib implementation) is throwing errors, maybe we should use better kind of errors instead of just
Error
with a message? 🤔Unchanged files with check annotations Beta
Check warning on line 12 in docker/services.dockerfile
Variables should be defined before their use
Check warning on line 12 in docker/services.dockerfile
Variables should be defined before their use
Check warning on line 13 in docker/services.dockerfile
Variables should be defined before their use
Check warning on line 14 in docker/services.dockerfile
Variables should be defined before their use
Check warning on line 14 in docker/services.dockerfile
Variables should be defined before their use
Check warning on line 20 in docker/services.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 21 in docker/services.dockerfile
Variables should be defined before their use
Check warning on line 21 in docker/services.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 21 in docker/services.dockerfile
Variables should be defined before their use
Check warning on line 21 in docker/services.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 22 in docker/services.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 22 in docker/services.dockerfile
Variables should be defined before their use
Check warning on line 10 in docker/migrations.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 10 in docker/migrations.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 11 in docker/migrations.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 12 in docker/migrations.dockerfile
Variables should be defined before their use
Check warning on line 12 in docker/migrations.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 15 in docker/migrations.dockerfile
Variables should be defined before their use
Check warning on line 15 in docker/migrations.dockerfile
Variables should be defined before their use
Check warning on line 17 in docker/migrations.dockerfile
Variables should be defined before their use
Check warning on line 12 in docker/cli.dockerfile
Variables should be defined before their use
Check warning on line 13 in docker/cli.dockerfile
Variables should be defined before their use
Check warning on line 14 in docker/cli.dockerfile
Variables should be defined before their use
Check warning on line 20 in docker/cli.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 21 in docker/cli.dockerfile
Legacy key/value format with whitespace separator should not be used
Check warning on line 21 in docker/cli.dockerfile
Variables should be defined before their use