-
Notifications
You must be signed in to change notification settings - Fork 123
chore(deps): Update ioredis to support connecting to Redis in IPv6 networks
#7333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @alexdaima, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the system's compatibility with modern network infrastructures by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The ioredis dependency is updated across multiple packages. My main concern is ensuring compatibility with other libraries that consume the ioredis instance, such as redlock and bentocache. I've highlighted a potential risk regarding this, especially since a beta version of redlock is in use, and I recommend verifying compatibility to avoid runtime issues. Additionally, as per the repository's style guide (lines 77-79), this change touches the services and should include a changeset file.
| "graphql-scalars": "1.24.2", | ||
| "graphql-yoga": "5.13.3", | ||
| "ioredis": "5.4.2", | ||
| "ioredis": "5.8.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating ioredis without also updating packages that depend on it, like redlock and bentocache, is risky. The redlock dependency is a beta version (5.0.0-beta.2), which increases the chance of incompatibility with [email protected].
Please verify compatibility or update these dependent packages to prevent potential runtime errors. This concern also applies to other services in this PR, for example the server package using @graphql-yoga/redis-event-target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. I'll do a thorough assessment when I get chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the ioredis package from version 5.4.2 to 5.8.2 across multiple service packages to enable IPv6 network connectivity support, addressing issue #7326.
Key Changes:
- Bumps
ioredisdependency to version 5.8.2 in 7 service package.json files - Updates pnpm-lock.yaml with new package resolution entries and dependency snapshots
- Includes updated transitive dependency
@ioredis/commandsfrom 1.2.0 to 1.4.0
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/services/api/package.json | Updates ioredis dependency from 5.4.2 to 5.8.2 |
| packages/services/emails/package.json | Updates ioredis dependency from 5.4.2 to 5.8.2 |
| packages/services/schema/package.json | Updates ioredis dependency from 5.4.2 to 5.8.2 |
| packages/services/server/package.json | Updates ioredis dependency from 5.4.2 to 5.8.2 |
| packages/services/tokens/package.json | Updates ioredis dependency from 5.4.2 to 5.8.2 |
| packages/services/usage/package.json | Updates ioredis dependency from 5.4.2 to 5.8.2 |
| packages/services/webhooks/package.json | Updates ioredis dependency from 5.4.2 to 5.8.2 |
| pnpm-lock.yaml | Adds new [email protected] resolution, updates all package references to use new version, includes @ioredis/[email protected] |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Background
Directly addresses:
ioredisto support connecting to Redis in IPv6 networks #7326Description
This update bumps the
ioredispackage to the required version in the relevantpackage.jsonfiles.Checklist
N/A