Skip to content

Conversation

@theguild-bot
Copy link
Collaborator

The examples converted from E2E tests have changed in 8b354f0.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated a key dependency across multiple example projects to ensure enhanced stability, improved performance, and compatibility with the latest enhancements.

Walkthrough

This pull request updates the version of the @graphql-hive/gateway dependency from ^1.10.0 to ^1.10.1 in multiple package.json files across various example directories. There are no other changes to dependencies, scripts, or configurations in any of the modified files.

Changes

File(s) Change Summary
examples/…/package.json (17 files) Updated @graphql-hive/gateway dependency version from ^1.10.0 to ^1.10.1 in each file.

Possibly related PRs

Suggested reviewers

  • dotansimha

Poem

Oh, what a hop, what a thrill today,
A little version bump in every way.
With dependencies neat and code so spry,
CodeRabbit hops by with a joyful sigh.
🐇 Cheers to changes that make our code fly!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b354f0 and 3998a14.

⛔ Files ignored due to path filters (34)
  • examples/apq-subgraphs/example.tar.gz is excluded by !**/*.gz
  • examples/apq-subgraphs/package-lock.json is excluded by !**/package-lock.json
  • examples/extra-fields/example.tar.gz is excluded by !**/*.gz
  • examples/extra-fields/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-example/example.tar.gz is excluded by !**/*.gz
  • examples/federation-example/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-mixed/example.tar.gz is excluded by !**/*.gz
  • examples/federation-mixed/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-subscriptions-passthrough/example.tar.gz is excluded by !**/*.gz
  • examples/federation-subscriptions-passthrough/package-lock.json is excluded by !**/package-lock.json
  • examples/file-upload/example.tar.gz is excluded by !**/*.gz
  • examples/file-upload/package-lock.json is excluded by !**/package-lock.json
  • examples/hmac-auth-https/example.tar.gz is excluded by !**/*.gz
  • examples/hmac-auth-https/package-lock.json is excluded by !**/package-lock.json
  • examples/interface-additional-resolvers/example.tar.gz is excluded by !**/*.gz
  • examples/interface-additional-resolvers/package-lock.json is excluded by !**/package-lock.json
  • examples/json-schema-subscriptions/example.tar.gz is excluded by !**/*.gz
  • examples/json-schema-subscriptions/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-additional-resolvers/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-additional-resolvers/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-arg-rename/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-arg-rename/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-javascript-wiki/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-javascript-wiki/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-subscriptions/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-subscriptions/package-lock.json is excluded by !**/package-lock.json
  • examples/operation-field-permissions/example.tar.gz is excluded by !**/*.gz
  • examples/operation-field-permissions/package-lock.json is excluded by !**/package-lock.json
  • examples/programmatic-batching/example.tar.gz is excluded by !**/*.gz
  • examples/programmatic-batching/package-lock.json is excluded by !**/package-lock.json
  • examples/subscriptions-with-transforms/example.tar.gz is excluded by !**/*.gz
  • examples/subscriptions-with-transforms/package-lock.json is excluded by !**/package-lock.json
  • examples/type-merging-batching/example.tar.gz is excluded by !**/*.gz
  • examples/type-merging-batching/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (17)
  • examples/apq-subgraphs/package.json (1 hunks)
  • examples/extra-fields/package.json (1 hunks)
  • examples/federation-example/package.json (1 hunks)
  • examples/federation-mixed/package.json (1 hunks)
  • examples/federation-subscriptions-passthrough/package.json (1 hunks)
  • examples/file-upload/package.json (1 hunks)
  • examples/hmac-auth-https/package.json (1 hunks)
  • examples/interface-additional-resolvers/package.json (1 hunks)
  • examples/json-schema-subscriptions/package.json (1 hunks)
  • examples/openapi-additional-resolvers/package.json (1 hunks)
  • examples/openapi-arg-rename/package.json (1 hunks)
  • examples/openapi-javascript-wiki/package.json (1 hunks)
  • examples/openapi-subscriptions/package.json (1 hunks)
  • examples/operation-field-permissions/package.json (1 hunks)
  • examples/programmatic-batching/package.json (1 hunks)
  • examples/subscriptions-with-transforms/package.json (1 hunks)
  • examples/type-merging-batching/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
`examples/**`: In this directory we keep all the examples. E...

examples/**: In this directory we keep all the examples. Examples are generated using a scheduled CI pipeline.
When changes are made to Gateway config, we expect to see some changes in the examples directory.

  • examples/extra-fields/package.json
  • examples/openapi-additional-resolvers/package.json
  • examples/type-merging-batching/package.json
  • examples/interface-additional-resolvers/package.json
  • examples/openapi-arg-rename/package.json
  • examples/federation-mixed/package.json
  • examples/subscriptions-with-transforms/package.json
  • examples/federation-subscriptions-passthrough/package.json
  • examples/json-schema-subscriptions/package.json
  • examples/federation-example/package.json
  • examples/programmatic-batching/package.json
  • examples/hmac-auth-https/package.json
  • examples/openapi-javascript-wiki/package.json
  • examples/apq-subgraphs/package.json
  • examples/operation-field-permissions/package.json
  • examples/file-upload/package.json
  • examples/openapi-subscriptions/package.json
`**`: For all PRs, we would like to verify that a Linear iss...

**: For all PRs, we would like to verify that a Linear issue is linked. Check if there's a mention for "GW-*" in the PR description, and the us know when it's missing.

In most cases, when a PR adds a new functionality, we would like to make sure it has documentation in the corresponding console project.
Use the global knowledge feature to search for PRs in graphql-hive/console repository that adds documentation. Suggest to create a follow up issue to add the missing documentation.

  • examples/extra-fields/package.json
  • examples/openapi-additional-resolvers/package.json
  • examples/type-merging-batching/package.json
  • examples/interface-additional-resolvers/package.json
  • examples/openapi-arg-rename/package.json
  • examples/federation-mixed/package.json
  • examples/subscriptions-with-transforms/package.json
  • examples/federation-subscriptions-passthrough/package.json
  • examples/json-schema-subscriptions/package.json
  • examples/federation-example/package.json
  • examples/programmatic-batching/package.json
  • examples/hmac-auth-https/package.json
  • examples/openapi-javascript-wiki/package.json
  • examples/apq-subgraphs/package.json
  • examples/operation-field-permissions/package.json
  • examples/file-upload/package.json
  • examples/openapi-subscriptions/package.json
⏰ Context from checks skipped due to timeout of 90000ms (25)
  • GitHub Check: E2E / Bun Docker on Ubuntu
  • GitHub Check: E2E / Bun on Ubuntu
  • GitHub Check: E2E / Node Binary on Windows
  • GitHub Check: E2E / Node Binary on Ubuntu
  • GitHub Check: E2E / Node Docker on Ubuntu
  • GitHub Check: Unit / Bun
  • GitHub Check: E2E / Node 23 on Ubuntu
  • GitHub Check: Leaks / Node v23
  • GitHub Check: E2E / Node 22 on Ubuntu
  • GitHub Check: Leaks / Node v22
  • GitHub Check: E2E / Node 20 on Ubuntu
  • GitHub Check: Leaks / Node v20
  • GitHub Check: E2E / Node 18 on Ubuntu
  • GitHub Check: Benchmark / bun / 1000 items
  • GitHub Check: Leaks / Node v18
  • GitHub Check: Benchmark / bun / 100 items
  • GitHub Check: Unit / Node v23
  • GitHub Check: Benchmark / bun / 10 items
  • GitHub Check: Benchmark / node / 1000 items
  • GitHub Check: Unit / Node v20
  • GitHub Check: Benchmark / node / 100 items
  • GitHub Check: Bundle
  • GitHub Check: Benchmark / node / 10 items
  • GitHub Check: Build
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (20)
examples/openapi-javascript-wiki/package.json (1)

10-10: LGTM! Patch version update of @graphql-hive/gateway.

The update from ^1.10.0 to ^1.10.1 is a patch version change, suggesting bug fixes or minor improvements.

examples/programmatic-batching/package.json (1)

10-10: LGTM! Consistent version update across examples.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistently applied across all example directories, which is expected as these examples are generated by the CI pipeline.

examples/subscriptions-with-transforms/package.json (3)

1-23: Missing Linear issue reference.

The PR description doesn't include a reference to a Linear issue (GW-*). Please add the corresponding Linear issue number to maintain traceability.


1-23:

❓ Verification inconclusive

Verify documentation requirements.

Since this is a version update in the examples, let's check if there are any breaking changes that require documentation updates.


🌐 Web query:

What are the changes in @graphql-hive/gateway version 1.10.1 compared to 1.10.0?

💡 Result:

Based on an analysis of all provided search results up to February 13, 2025, there is no mention of @graphql-hive/gateway versions 1.10.0 or 1.10.1 in any release notes or documentation[1][4][7]. The latest documented releases for this package are:

Version Release Date Key Changes
1.9.4 February 6, 2025 Removed custom abort signal dependencies in favor of native APIs[1][4]
1.9.3 February 4, 2025 Fixed WebSocket client regression[1]
1.9.2 February 4, 2025 Upgraded graphql-ws to v6 with breaking changes[1]
1.9.x January 2025 Added cache configuration improvements[10]

The search results contain no evidence of a v1.10.x release branch existing for @graphql-hive/gateway as of February 13, 2025[1][4][7][10]. This could indicate either:

  • A typo in version numbers
  • A withdrawn/unreleased version
  • Version numbering that hasn't reached v1.10.x yet

For authoritative version history, check GitHub Releases directly[1].

Citations:


Action Required: Confirm the Version Bump and Its Documentation

The update bumps @graphql-hive/gateway to ^1.10.1, but our web query shows no official release notes or documentation for versions 1.10.0 or 1.10.1. Please verify that this version number is correct:

  • If the update reflects an unreleased or internal version, ensure that any breaking changes (if any) are properly documented.
  • If this is a typo or unintended version bump, update the package version accordingly.

10-10:

❓ Verification inconclusive

Consistent version update across examples.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistently applied across all example projects.

Let's verify this version:


🏁 Script executed:

#!/bin/bash
# Description: Check for security advisories and latest versions of the @graphql-hive/gateway package

# Check npm for latest versions
npm view @graphql-hive/gateway versions --json

# Check for security advisories
npm audit @graphql-hive/gateway

Length of output: 65967


Action Required: Verify @graphql-hive/gateway Version Update

The package.json in examples/subscriptions-with-transforms now specifies:

"@graphql-hive/gateway": "^1.10.1"

Though the change is applied uniformly across the examples, our automated check using npm view @graphql-hive/gateway versions --json returned a very long list of published versions that—based on the output—do not appear to include a release in the “1.10.x” series. In addition, the subsequent npm audit command failed due to a missing lockfile.

Please verify manually that version 1.10.1 exists (or is intended) as expected, and that its security status is acceptable.

examples/federation-subscriptions-passthrough/package.json (1)

18-18: LGTM: Version update is consistent.

The update of @graphql-hive/gateway to ^1.10.1 is consistent with the coordinated version update across examples.

examples/hmac-auth-https/package.json (1)

15-15: LGTM: Version update is consistent.

The update of @graphql-hive/gateway to ^1.10.1 is consistent with the coordinated version update across examples.

examples/openapi-additional-resolvers/package.json (1)

10-10: LGTM! Consistent version update across examples.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistently applied across all example directories, which is good for maintaining version parity.

examples/extra-fields/package.json (1)

9-9: LGTM! Consistent version update across all examples.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is applied consistently across all example directories.

examples/operation-field-permissions/package.json (1)

9-9: Missing Linear issue reference.

Please add a reference to the corresponding Linear issue (GW-*) in the PR description for better tracking.

examples/federation-example/package.json (1)

12-12: LGTM!

The version update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent across all example directories.

examples/federation-mixed/package.json (2)

12-12: LGTM!

The version update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent across all example directories.


1-29: Missing Linear issue reference.

According to the coding guidelines, we need to verify that a Linear issue is linked. Please add a reference to the corresponding "GW-*" issue in the PR description.

examples/file-upload/package.json (1)

8-8: LGTM! Version update looks good.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent with other example directories.

examples/apq-subgraphs/package.json (1)

12-12: LGTM! Version update looks good.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent with other example directories.

examples/interface-additional-resolvers/package.json (1)

9-9: LGTM! Version update looks good.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent with other example directories.

examples/openapi-arg-rename/package.json (1)

10-10: LGTM! Version update looks good.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent with other example directories.

examples/type-merging-batching/package.json (1)

9-9: LGTM! Version update looks good.

The update of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent with other example directories.

examples/openapi-subscriptions/package.json (1)

12-12: LGTM!

The patch version bump of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent across examples and appears to be automatically generated.

examples/json-schema-subscriptions/package.json (1)

13-13: LGTM!

The patch version bump of @graphql-hive/gateway from ^1.10.0 to ^1.10.1 is consistent with other examples.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ardatan ardatan merged commit 8ce3a4b into main Feb 13, 2025
43 checks passed
@ardatan ardatan deleted the examples/update branch February 13, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants