Skip to content

feat: Add FielNameRewriter #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions src/rewriters/FieldNameRewriter.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import { ASTNode, FieldNode } from 'graphql';
import Rewriter, { RewriterOpts } from './Rewriter';
import { NodeAndVarDefs } from '../ast';

interface FieldNameRewriterOpts extends RewriterOpts {
newFieldName: string;
}

export default class FieldNameRewriter extends Rewriter {
protected newFieldName: string;

constructor(options: FieldNameRewriterOpts) {
super(options);
this.newFieldName = options.newFieldName;
}

public matches(nodeAndVars: NodeAndVarDefs, parents: ASTNode[]) {
if (!super.matches(nodeAndVars, parents)) return false;
const node = nodeAndVars.node as FieldNode;
if (node.kind !== 'Field') return false;
if (node.name.value !== this.fieldName) return false;
return true;
}

public rewriteQuery(nodeAndVarDefs: NodeAndVarDefs): NodeAndVarDefs {
const node = nodeAndVarDefs.node as FieldNode;
const { variableDefinitions } = nodeAndVarDefs;
const updatedNode = {
...node,
name: { kind: 'Name', value: this.newFieldName }
} as FieldNode;

return { node: updatedNode, variableDefinitions };
}

public rewriteResponse(response: any, key: string, index?: number): any {
const element = super.extractReponseElement(response, key, index);
super.rewriteResponseElement(response, element, this.fieldName, index);
return super.deleteResponseElement(response, this.newFieldName, index);
}
}
17 changes: 17 additions & 0 deletions src/rewriters/Rewriter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,23 @@ abstract class Rewriter {

return response;
}

protected deleteResponseElement(response: any, key: string, index?: number): any {
// Verify the response format
if (response === null || typeof response !== 'object') return response;

// Extract the key
const element = response[key];

// Extract the position
if (Array.isArray(element)) {
element.splice(index!, 1);
} else {
delete response[key];
}

return response;
}
}

export default Rewriter;
1 change: 1 addition & 0 deletions src/rewriters/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ export { default as Rewriter, RewriterOpts } from './Rewriter';
export { default as FieldArgNameRewriter } from './FieldArgNameRewriter';
export { default as FieldArgsToInputTypeRewriter } from './FieldArgsToInputTypeRewriter';
export { default as FieldArgTypeRewriter } from './FieldArgTypeRewriter';
export { default as FieldNameRewriter } from './FieldNameRewriter';
export { default as NestFieldOutputsRewriter } from './NestFieldOutputsRewriter';
export { default as ScalarFieldToObjectFieldRewriter } from './ScalarFieldToObjectFieldRewriter';
export { default as JsonToTypedObjectRewriter } from './JsonToTypedObjectRewriter';
101 changes: 101 additions & 0 deletions test/functional/rewriteFieldName.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
import RewriteHandler from '../../src/RewriteHandler';
import FieldNameRewriter from '../../src/rewriters/FieldNameRewriter';
import { gqlFmt } from '../testUtils';

describe('Rewrite field name', () => {
it('allows rewriting the name of a field', () => {
const handler = new RewriteHandler([
new FieldNameRewriter({
fieldName: 'createThing',
newFieldName: 'thingCreate'
})
]);

const query = gqlFmt`
mutation createMyThings {
createThing {
myThingId
}
otherMutation {
otherField
}
}
`;
const expectedRewritenQuery = gqlFmt`
mutation createMyThings {
thingCreate {
myThingId
}
otherMutation {
otherField
}
}
`;
expect(handler.rewriteRequest(query)).toEqual({
query: expectedRewritenQuery,
variables: undefined
});

const response = {
thingCreate: {
myThingId: 'meh'
},
otherMutation: {
otherField: 18
}
};
const expectedResponse = {
createThing: {
myThingId: 'meh'
},
otherMutation: {
otherField: 18
}
};
expect(handler.rewriteResponse(response)).toEqual(expectedResponse);
});

it('allows rewriting the name of a field in array', () => {
const handler = new RewriteHandler([
new FieldNameRewriter({
fieldName: 'myThingId',
newFieldName: 'id'
})
]);

const query = gqlFmt`
mutation createMyThings {
createThings {
myThingId
}
}
`;
const expectedRewritenQuery = gqlFmt`
mutation createMyThings {
createThings {
id
}
}
`;
expect(handler.rewriteRequest(query)).toEqual({
query: expectedRewritenQuery,
variables: undefined
});

const response = {
createThings: [
{
id: '1'
}
]
};
const expectedResponse = {
createThings: [
{
myThingId: '1'
}
]
};
expect(handler.rewriteResponse(response)).toEqual(expectedResponse);
});
});