Skip to content

editorconfig + clippy + PartialEq - #4

Merged
tailhook merged 2 commits into
graphql-rust:masterfrom
Keats:housekeeping
Feb 7, 2018
Merged

editorconfig + clippy + PartialEq#4
tailhook merged 2 commits into
graphql-rust:masterfrom
Keats:housekeeping

Conversation

@Keats

@Keats Keats commented Feb 7, 2018

Copy link
Copy Markdown

I've done a first pass for clippy but didn't change it all in case it was clashing with your code style. The main 2 clippy lints left are:

108 |                 if line.trim().len() != 0 {
    |                    ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is more concise: `!line.trim().is_empty()`

and

199 |     return Ok(result);
    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`

If you're ok with changing those, I'll do it in another commit

@Keats Keats changed the title editorconfig + clippy editorconfig + clippy + PartialEq Feb 7, 2018
@tailhook
tailhook merged commit fe82e17 into graphql-rust:master Feb 7, 2018
@tailhook

tailhook commented Feb 7, 2018

Copy link
Copy Markdown
Collaborator

is_empty is fine.

Implicit return is good in Ok(..) case or in one-liners. But pretty much dislike when it fixes it everywhere.

@tailhook

tailhook commented Feb 7, 2018

Copy link
Copy Markdown
Collaborator

Thanks for your work. Should I give you permissions, so you can work on it freely?

@Keats
Keats deleted the housekeeping branch February 7, 2018 12:51
@Keats

Keats commented Feb 7, 2018

Copy link
Copy Markdown
Author

Thanks for your work. Should I give you permissions, so you can work on it freely?

Up to you! I would still go through PRs to make sure changes are ok either way

@tailhook

tailhook commented Feb 7, 2018

Copy link
Copy Markdown
Collaborator

Up to you! I would still go through PRs to make sure changes are ok either way

Added, just to increase bus factor and so you can triage other's issues. Feel free to open PRs of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants