editorconfig + clippy + PartialEq - #4
Merged
Conversation
Collaborator
|
Implicit return is good in |
Collaborator
|
Thanks for your work. Should I give you permissions, so you can work on it freely? |
Author
Up to you! I would still go through PRs to make sure changes are ok either way |
Collaborator
Added, just to increase bus factor and so you can triage other's issues. Feel free to open PRs of course :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done a first pass for clippy but didn't change it all in case it was clashing with your code style. The main 2 clippy lints left are:
and
If you're ok with changing those, I'll do it in another commit