Skip to content

feat: fragment variables #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/query/ast.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ pub enum Definition<'a, T: Text<'a>> {
pub struct FragmentDefinition<'a, T: Text<'a>> {
pub position: Pos,
pub name: T::Value,
pub variable_definitions: Vec<VariableDefinition<'a, T>>,
pub type_condition: TypeCondition<'a, T>,
pub directives: Vec<Directive<'a, T>>,
pub selection_set: SelectionSet<'a, T>,
Expand Down Expand Up @@ -118,6 +119,7 @@ pub struct Field<'a, T: Text<'a>> {
pub struct FragmentSpread<'a, T: Text<'a>> {
pub position: Pos,
pub fragment_name: T::Value,
pub arguments: Vec<(T::Value, Value<'a, T>)>,
pub directives: Vec<Directive<'a, T>>,
}

Expand Down
10 changes: 10 additions & 0 deletions src/query/format.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ impl<'a, T: Text<'a>> Displayable for FragmentDefinition<'a, T> {
f.indent();
f.write("fragment ");
f.write(self.name.as_ref());
if !self.variable_definitions.is_empty() {
f.write("(");
self.variable_definitions[0].display(f);
for var in &self.variable_definitions[1..] {
f.write(", ");
var.display(f);
}
f.write(")");
}
f.write(" ");
self.type_condition.display(f);
format_directives(&self.directives, f);
Expand Down Expand Up @@ -322,6 +331,7 @@ impl<'a, T: Text<'a>> Displayable for FragmentSpread<'a, T> {
f.indent();
f.write("...");
f.write(self.fragment_name.as_ref());
format_arguments(&self.arguments, f);
format_directives(&self.directives, f);
f.endline();
}
Expand Down
56 changes: 44 additions & 12 deletions src/query/grammar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,20 @@ where
},
)
.map(Selection::InlineFragment)
.or((position(), name::<'a, S>(), parser(directives))
.map(|(position, fragment_name, directives)| FragmentSpread {
position,
fragment_name,
directives,
})
.or((
position(),
name::<'a, S>(),
parser(arguments),
parser(directives),
)
.map(
|(position, fragment_name, arguments, directives)| FragmentSpread {
position,
fragment_name,
arguments,
directives,
},
)
.map(Selection::FragmentSpread)),
))
.parse_stream(input)
Expand Down Expand Up @@ -219,17 +227,41 @@ pub fn fragment_definition<'a, T: Text<'a>>(
(
position().skip(ident("fragment")),
name::<'a, T>(),
optional(
punct("(")
.with(many1(
(
position(),
punct("$").with(name::<'a, T>()).skip(punct(":")),
parser(parse_type),
optional(punct("=").with(parser(default_value))),
)
.map(|(position, name, var_type, default_value)| {
VariableDefinition {
position,
name,
var_type,
default_value,
}
}),
))
.skip(punct(")")),
)
.map(|vars| vars.unwrap_or_default()),
ident("on").with(name::<'a, T>()).map(TypeCondition::On),
parser(directives),
parser(selection_set),
)
.map(
|(position, name, type_condition, directives, selection_set)| FragmentDefinition {
position,
name,
type_condition,
directives,
selection_set,
|(position, name, variable_definitions, type_condition, directives, selection_set)| {
FragmentDefinition {
position,
name,
variable_definitions,
type_condition,
directives,
selection_set,
}
},
)
.parse_stream(input)
Expand Down
7 changes: 7 additions & 0 deletions tests/queries/fragment_spread_arguments.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
query {
node {
id
...something(arg: "test")
...somethingElse(arg2: $var)
}
}
3 changes: 3 additions & 0 deletions tests/queries/fragment_variables.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
fragment frag($arg: String!) on Friend {
node
}
8 changes: 8 additions & 0 deletions tests/query_roundtrips.rs
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@ fn fragment_spread() {
roundtrip_default("fragment_spread");
}
#[test]
fn fragment_spread_arguments() {
roundtrip_default("fragment_spread_arguments");
}
#[test]
fn minimal_mutation() {
roundtrip_default("minimal_mutation");
}
Expand All @@ -160,6 +164,10 @@ fn fragment() {
roundtrip_default("fragment");
}
#[test]
fn fragment_variables() {
roundtrip_default("fragment_variables");
}
#[test]
fn directive_args() {
roundtrip_default("directive_args");
}
Expand Down