Skip to content

Lint GitHub Actions #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2022
Merged

Lint GitHub Actions #3614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ jobs:
- name: Spellcheck
run: npm run check:spelling

- name: Lint GitHub Actions
uses: docker://rhysd/actionlint:latest
with:
args: -color

checkForCommonlyIgnoredFiles:
name: Check for commonly ignored files
runs-on: ubuntu-latest
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/cmd-publish-pr-on-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ on:
workflow_call:
inputs:
pullRequestJSON:
description: String that contain JSON payload for `pull_request` event.
required: true
type: string
secrets:
NPM_CANARY_PR_PUBLISH_TOKEN:
description: NPM token to publish canary release.
required: true
jobs:
build-npm-dist:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/cmd-run-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
workflow_call:
inputs:
pullRequestJSON:
description: String that contain JSON payload for `pull_request` event.
required: true
type: string
jobs:
Expand All @@ -19,7 +20,7 @@ jobs:
- name: Deepen cloned repo
env:
BASE_SHA: ${{ fromJSON(inputs.pullRequestJSON).base.sha }}
run: 'git fetch --depth=1 origin $BASE_SHA:refs/tags/BASE'
run: 'git fetch --depth=1 origin "$BASE_SHA:refs/tags/BASE"'

- name: Setup Node.js
uses: actions/setup-node@v2
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/deploy-artifact-as-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@ on:
workflow_call:
inputs:
environment:
description: Environment to publish under
required: true
type: string
artifact_name:
description: Artifact name
required: true
type: string
target_branch:
description: Target branch
required: true
type: string
commit_message:
description: Commit message
required: true
type: string
jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Deepen cloned repo
env:
BASE_SHA: ${{ github.event.pull_request.base.sha }}
run: 'git fetch --depth=1 origin $BASE_SHA:refs/tags/BASE'
run: 'git fetch --depth=1 origin "$BASE_SHA:refs/tags/BASE"'

- name: Setup Node.js
uses: actions/setup-node@v2
Expand Down