Fix incorrect FormattedCompletedResult fields and add a FormattedPendingResult
#4481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerelmiller
commented
Sep 8, 2025
| @@ -156,15 +156,20 @@ export interface PendingResult { | |||
| label?: string; | |||
| } | |||
|
|
|||
| export interface FormattedPendingResult { | |||
There was a problem hiding this comment.
I know there is a bit of back and forth on whether this should exist, but I went ahead and added it to continue the pattern of using Formatted* types. This is also useful as a library author so I don't have to guess why PendingResult exists, but not FormattedPendingResult.
I'm happy to pull this out if ultimately you decide it should use PendingResult. The real change I'm interested in for this fix anyways is the change to FormattedCompletedResult.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4333
This change fixes the fields in
FormattedCompletedResultto matchCompletedResult(i.e.idanderrors) using theFormatted*type variants. This change also adds aFormattedPendingResultas an counterpart toPendingResultto match the type patterns already established with otherFormatted*types.I ran into this issue when working on adding support for the new incremental format in Apollo Client (apollographql/apollo-client#12906).