Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework specification with a focus on backwards compatibility #175

Merged
merged 34 commits into from
Jun 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
67bd4aa
Start editing spec
benjie Jun 6, 2022
b497a04
GraphQL server -> server; GraphQL client -> client
benjie Jun 6, 2022
1a0295c
Content-Types
benjie Jun 6, 2022
33312e7
Request edits
benjie Jun 6, 2022
1024611
Rework Content-Types and start work on Response
benjie Jun 6, 2022
d9cc4e0
Status codes differ between media types
benjie Jun 7, 2022
9de810f
Special case for data:null
benjie Jun 7, 2022
d16bd87
Update wording around status codes
benjie Jun 7, 2022
85f3dbf
Revisions from second read-through
benjie Jun 8, 2022
1cc2e0e
Another editing pass
benjie Jun 8, 2022
01eeced
Update spec/GraphQLOverHTTP.md
benjie Jun 8, 2022
860926d
Apply suggestions from code review
benjie Jun 9, 2022
0fc5e96
Clarify server parsing (suggestion by @ghmcadams)
benjie Jun 9, 2022
c7ac462
Move media type rules to media type section
benjie Jun 9, 2022
b4a4f8b
Prettier
benjie Jun 9, 2022
d443805
Move 'JSON Encoding' section into POST section
benjie Jun 9, 2022
9b75235
'X in the GraphQL specification' -> 'GraphQL's X'
benjie Jun 9, 2022
264f5b4
-we
benjie Jun 9, 2022
bdd59d1
Correct typo
benjie Jun 9, 2022
40afab8
Add @ghmcadams' suggestions (modified)
benjie Jun 11, 2022
4139284
Reword
benjie Jun 11, 2022
8190e25
Apply @spawnia's improvement
benjie Jun 14, 2022
ba4be9b
You must assume UTF-8 (thanks @spawnia)
benjie Jun 14, 2022
78a1e33
Client MUST indicate Content-Type - thanks @michaelstaib
benjie Jun 14, 2022
9ef4e92
Make it clearer we're referring to a term
benjie Jun 14, 2022
e8e6660
Prettier
benjie Jun 14, 2022
b566f21
Grammar (thanks @spawnia)
benjie Jun 14, 2022
8b412d8
Fix the formatting of POST example
benjie Jun 14, 2022
fcc0acf
Clarify non-normative note about authorization decisions
benjie Jun 14, 2022
a737acc
Clarification around client Accept header
benjie Jun 14, 2022
01b7aa3
Consistently format variables
benjie Jun 14, 2022
e3cc093
Remove 'application/graphql+json' as encoding of request body
benjie Jun 17, 2022
79ed814
Move the "AS IS" fullstop to match GraphQL spec
benjie Jun 17, 2022
bd4f3fb
Grammar (thanks @ghmcadams)
benjie Jun 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions INTERESTED_DEVELOPERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ involved with the following steps:
GraphQL-over-HTTP working group. Given our world-wide span over many
timezones, we are doing an experiment of attempting to advance the spec with
fewer meetings and more asynchronous communication. During this experiment,
please reach out over slack and github.
please reach out over Discord and GitHub.
3. Add yourself to `List of Developers` below.
4. Find our working group on the
[GraphQL Foundation slack community](https://slack.graphql.org) in the
[graphql-over-http channel](https://graphql.slack.com/archives/CRTKLUZRT).
[GraphQL Foundation Discord community](https://discord.graphql.org) in the
#graphql-over-http channel.

## List of Developers

Expand Down
17 changes: 12 additions & 5 deletions ROADMAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,18 @@ client and server are compliant._

## Version 1.0

After significant meetings, the Working Group has come to consensus that a first
version of this spec should introduce some key changes over the prior existing
uses of GraphQL over HTTP. This first version _might_ also codify existing prior
common usages of GraphQL over HTTP. In layout and structure version 1.0 should
lay a foundation for future development and standardization.
Version 1 aims to codify the most common existing uses of GraphQL queries and
mutations over HTTP whilst encouraging some improved practices. The majority of
GraphQL servers should find that they are already compatible with Version 1.0 of
the GraphQL-over-HTTP specification, although they should still put work in to
address the `SHOULD` behaviours that they may be missing, most notably around
the use of the `application/graphql+json` Content-Type.

Subscriptions, websockets and server-sent events are out of scope for version
1.0.

In layout and structure version 1.0 should lay a foundation for future
development and standardization.

### Scope

Expand Down
Loading