Skip to content

Perf and stability improve for lib/srv/regular - #64877

Merged
russjones merged 1 commit into
masterfrom
rjones/improve-tests-1
Aug 8, 2026
Merged

Perf and stability improve for lib/srv/regular#64877
russjones merged 1 commit into
masterfrom
rjones/improve-tests-1

Conversation

@russjones

@russjones russjones commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Parallelized and increased frequency of checks for many tests.

Stabilized the following tests.

  • TestAllowedLabels
  • TestDirectTCPIP
  • TestLockInForce
  • TestTCPIPForward
  • TestAgentForward
  • TestX11Forward

Original flaky behavior for the above tests can be reproduced using stress with the following command:

go test -o flaky.test ./... && \
  stress -p 30 -failfast ./flaky.test -test.run="TestName"

The following tests still show up when running the full test suite for lib/srv/regular under stress.

@russjones russjones added the no-changelog Indicates that a PR does not require a changelog entry label Mar 19, 2026
zmb3
zmb3 reviewed Mar 20, 2026
View reviewed changes
Comment thread lib/srv/regular/sshserver_test.go Outdated
Comment thread lib/srv/regular/sshserver_test.go Outdated
Comment thread lib/srv/regular/sshserver_test.go
Comment thread lib/srv/regular/sshserver_test.go Outdated
Comment thread lib/srv/regular/sshserver_test.go Outdated
Comment thread lib/srv/regular/sshserver.go Outdated
rosstimothy
rosstimothy reviewed Mar 20, 2026
View reviewed changes
Comment thread lib/srv/regular/sshserver_test.go Outdated
claude[bot]
claude Bot reviewed Apr 1, 2026
View reviewed changes
Comment thread lib/srv/regular/sshserver_test.go
Comment thread lib/srv/regular/sshserver_test.go
Joerger
Joerger reviewed Apr 2, 2026
View reviewed changes
Comment thread lib/srv/regular/sshserver.go Outdated
Comment thread lib/srv/reexec.go
@russjones
russjones force-pushed the rjones/improve-tests-1 branch 2 times, most recently from f074e4c to 74a64bf Compare April 3, 2026 02:39
rosstimothy
rosstimothy reviewed Apr 10, 2026
View reviewed changes
Comment thread lib/srv/regular/sshserver.go Outdated
Comment thread lib/srv/regular/sshserver.go Outdated
Comment thread lib/srv/regular/sshserver.go Outdated
Comment thread lib/srv/regular/sshserver.go Outdated
Comment thread lib/srv/regular/sshserver.go Outdated
@russjones
russjones force-pushed the rjones/improve-tests-1 branch 2 times, most recently from 5b2972e to 03a3183 Compare May 29, 2026 21:17
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

+ 48 passed
! 1 flaky
# 7 skipped
# 2m 57s

Flaky

[firefox] e2e/tests/web/unauthenticated/signup.spec.ts:28

verify that a user can sign up with webauthn and login

Initial failure:

Test timeout of 60000ms exceeded.

Initial failure:

Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
  - waiting for getByRole('button', { name: 'Next' })


   at ../helpers/signup.ts:49

  47 |     .press('Tab');
  48 |   await page.getByRole('textbox', { name: 'Confirm Password' }).fill(password);
> 49 |   await page.getByRole('button', { name: 'Next' }).click();
     |                                                    ^
  50 |   await page.getByRole('button', { name: 'Create an MFA Method' }).click();
  51 |   await page.getByRole('button', { name: 'Submit' }).click();
  52 |   await page.getByRole('button', { name: 'Go to Cluster' }).click();
    at signup (/__w/teleport/teleport/e2e/helpers/signup.ts:49:52)
    at /__w/teleport/teleport/e2e/tests/web/unauthenticated/signup.spec.ts:35:3
View full report
./e2e/run.sh --report 64877 --sha 03a31832

rosstimothy
rosstimothy reviewed Jun 1, 2026
View reviewed changes
Comment thread lib/srv/regular/sshserver_test.go Outdated
Comment thread session/reexec/reexec.go
Joerger
Joerger reviewed Jun 25, 2026
View reviewed changes
Comment thread lib/srv/regular/sshserver.go Outdated
Comment thread session/reexec/reexec.go
Joerger
Joerger reviewed Jun 25, 2026
View reviewed changes
Comment thread lib/srv/regular/sshserver.go Outdated
Comment thread lib/srv/regular/sshserver_test.go Outdated
@russjones
russjones force-pushed the rjones/improve-tests-1 branch from 981f54a to efb731a Compare July 30, 2026 00:24
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 30, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f261697c21

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread lib/srv/regular/sshserver.go
@russjones

russjones commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@rosstimothy @Joerger Applied all requested changes, do you guys mind doing another pass?

@public-teleport-github-review-bot
public-teleport-github-review-bot Bot removed the request for review from jimbishopp August 5, 2026 22:58
@russjones
russjones force-pushed the rjones/improve-tests-1 branch from 3607a11 to b47e9c0 Compare August 6, 2026 00:11
@russjones
russjones enabled auto-merge August 6, 2026 00:11
@russjones
russjones disabled auto-merge August 8, 2026 00:34
@russjones
Perf and stability improve for lib/srv/regular
ebdb9ca 
Parallelized and increased frequency of checks for many tests.

Stabilized the following tests.

* TestAllowedLabels
* TestDirectTCPIP
* TestLockInForce
* TestTCPIPForward
* TestAgentForward
* TestX11Forward

Original flaky behavior for the above tests can be reproduced using
[stress](https://pkg.go.dev/golang.org/x/tools/cmd/stress) with the
following command:

```
go test -o flaky.test ./... && \
  stress -p 30 -failfast ./flaky.test -test.run="TestName"
```

The following tests still show up when running the full test suite for
`lib/srv/regular` under `stress`.

* TestMultipleExecCommands
* TestSessionAuditLog
@russjones
russjones force-pushed the rjones/improve-tests-1 branch from f56a1d5 to ebdb9ca Compare August 8, 2026 00:41
@russjones
russjones enabled auto-merge August 8, 2026 00:56
@russjones
russjones added this pull request to the merge queue Aug 8, 2026
Merged via the queue into master with commit e0d3c67 Aug 8, 2026
47 checks passed
@russjones
russjones deleted the rjones/improve-tests-1 branch August 8, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@claude claude[bot] claude[bot] left review comments
@Joerger Joerger Joerger approved these changes
@rosstimothy rosstimothy rosstimothy approved these changes
@eriktate eriktate Awaiting requested review from eriktate
@zmb3 zmb3 Awaiting requested review from zmb3

Assignees

No one assigned

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@russjones @zmb3 @eriktate @Joerger @rosstimothy