Use go tool to run protoc-gen-terraform - #69437
Merged
Merged
Conversation
hugoShaka
requested review from
doggydogworld,
klizhentas,
mjsmithnh,
r0mant,
rosstimothy,
russjones,
tigrato and
zmb3
as code owners
August 6, 2026 20:23
zmb3
approved these changes
Aug 6, 2026
zmb3
left a comment
Collaborator
There was a problem hiding this comment.
Seems fine, though you might consider following the dedicated-go.mod pattern that we have under build.assets/tools.
r0mant
approved these changes
Aug 6, 2026
Contributor
Author
I'm not super comfortable with the makefile crimes we're committing to do this: Lines 57 to 67 in 8ea6a9b I also spent 5 hours debugging this because the hacks we did doesn't work with exported variables and |
bernardjkim
approved these changes
Aug 7, 2026
hugoShaka
force-pushed
the
hugo/tf-protoc-go-tool
branch
from
August 7, 2026 17:25
fcf27f1 to
6460dc5
Compare
Contributor
|
@hugoShaka See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses
go toolto install and manage theprotoc-gen-terraformplugin responsible for generating the Terraform schemas.This provides the following benefits: