add: support setting proxy via custom env vars#80
Merged
Conversation
Conventional Commits Report
🚀 Conventional commits found. |
On second thought this feature is probably not expected by users. Furthermore in a container orchestration scenario it is usually not trivial to set an environment variable only conditionally. This would make it also difficult to use this feature.
Member
Author
|
I removed the distinction env var unset -> use Now it is in both cases: use On second thought the distinction is probably a rather unexpected bahavior. And I don't see a strong need for such a feature to justify this. Especially in a kubernetes deployment etc. it is also not so easy to conditionally set an env var. Making it even less useful. |
llugin
reviewed
Jun 17, 2025
Co-authored-by: llugin <leszek.lugin@greenbone.net>
llugin
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Support setting proxy via custom env vars
CSAF_DL_HTTP_PROXYandCSAF_DL_HTTPS_PROXY.If set to a non empty string, they will take precedence over
http_proxyandhttps_proxyand also their upper case versions.Why
There are scenarios where we want to apply a proxy only for the CSAF Downloader. Setting
http_proxyandhttps_proxyusually affects several other tools running in the same environment. So having the option to use the custom env vars allows us to avoid that.References
VTI-619
Checklist