Split different Filter parsing#5425
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
The former fromElement method of the Filter model did mix parsing of different XML responses. First for the `<get_filters>` responses and second for all filters included in all other get responses like `<get_tasks>`.
bjoernricks
force-pushed
the
filter-response-element
branch
from
July 16, 2026 10:20
9cf8978 to
f98ce00
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5425 +/- ##
=======================================
Coverage 80.96% 80.97%
=======================================
Files 1270 1270
Lines 33083 33090 +7
Branches 9913 9963 +50
=======================================
+ Hits 26786 26793 +7
Misses 5615 5615
Partials 682 682 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bjoernricks
marked this pull request as ready for review
July 16, 2026 10:35
bjoernricks
enabled auto-merge (rebase)
July 16, 2026 10:35
daniele-mng
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split different Filter parsing
Why
Split parsing filter responses from filter model responses. Filter model responses are returned by
<get_filters>only. Filter responses are included in all other<get_xyz>responses to define which filter has been used for the query.For example
<get_tasks>returns the following XML structureThis XML structure is now parsed by
fromResponseElement.A
<get_filters>XML response looks likeThis structure is parsed by
Filter.fromElement.References
https://jira.greenbone.net/browse/GEA-1933
Checklist