Skip to content

GEA-1698#5429

Merged
bjoernricks merged 2 commits into
mainfrom
GEA-1698-2
Jul 17, 2026
Merged

GEA-1698#5429
bjoernricks merged 2 commits into
mainfrom
GEA-1698-2

Conversation

@daniele-mng

@daniele-mng daniele-mng commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

What

  • Fix: in edit scan configs the column of select is clickable.
  • Fix: Avoid parent/child component overwriting the previous saved settings when closing dialog by clicking save.
  • Added test to ensure that the values are clickable and parent/child updates are mantained.

Why

  • Refactoring made the column not clickable.
  • When changes to a family were made via the child dialog it could be overwritten by the parent.
    Example: parent has selected, child has all rows selected, one gets deselected, but the parent status was not updated, therefore leaving it a selected, once save is clicked in the parent to close the dialog the values is overwritten.

References

GEA-1698

Checklist

  • Tests

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2e2b0ab.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

When saving in nested dialog the selected rows, it would not reflect in the parent dialog, therefore overwriting the previously saved value.

Update ScanConfigEditDialog.test.tsx
@daniele-mng
daniele-mng marked this pull request as ready for review July 17, 2026 10:41
@daniele-mng
daniele-mng requested a review from a team as a code owner July 17, 2026 10:41
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.98%. Comparing base (225fc30) to head (2e2b0ab).

Files with missing lines Patch % Lines
src/web/pages/scanconfigs/ScanConfigEditDialog.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5429   +/-   ##
=======================================
  Coverage   80.97%   80.98%           
=======================================
  Files        1270     1270           
  Lines       33090    33104   +14     
  Branches     9918     9926    +8     
=======================================
+ Hits        26794    26808   +14     
  Misses       5614     5614           
  Partials      682      682           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjoernricks
bjoernricks merged commit df2250d into main Jul 17, 2026
27 checks passed
@bjoernricks
bjoernricks deleted the GEA-1698-2 branch July 17, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants