GEA-1698#5429
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
When saving in nested dialog the selected rows, it would not reflect in the parent dialog, therefore overwriting the previously saved value. Update ScanConfigEditDialog.test.tsx
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5429 +/- ##
=======================================
Coverage 80.97% 80.98%
=======================================
Files 1270 1270
Lines 33090 33104 +14
Branches 9918 9926 +8
=======================================
+ Hits 26794 26808 +14
Misses 5614 5614
Partials 682 682 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bjoernricks
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Example: parent has selected, child has all rows selected, one gets deselected, but the parent status was not updated, therefore leaving it a selected, once save is clicked in the parent to close the dialog the values is overwritten.
References
GEA-1698
Checklist