Require Model ID#5443
Merged
Merged
Conversation
greenbonebot
enabled auto-merge (rebase)
July 22, 2026 11:13
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
All EntityModels need to have an id now.
Allow to pass different init data to the model testing helpers. This is required if some model requires additional data besides the id.
Set id for all model tests now it's required.
bjoernricks
force-pushed
the
require-model-id
branch
from
July 22, 2026 12:27
0b0c85f to
e59f8dc
Compare
daniele-mng
approved these changes
Jul 23, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Require Model ID
Why
With the split of the filter into two different classes it is now possible to require the id for all model classes. Filter was the only model that couldn't have an ID. The Filter model class implemented several use cases where no ID is available. These cases are now split into a different class.
References
https://jira.greenbone.net/browse/GEA-1957
Checklist