Skip to content

GEA-1719 - #5473

Merged
bjoernricks merged 3 commits into
mainfrom
GEA-1719
Aug 3, 2026
Merged

GEA-1719#5473
bjoernricks merged 3 commits into
mainfrom
GEA-1719

Conversation

@daniele-mng

Copy link
Copy Markdown
Contributor

What

Add: new method isLoggingOut to keep track and do not call renew_session gmp command.

Why

Fix: When logging out, the call gmp command renew_session gets called.

References

GEA-1719

Checklist

  • Tests

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 168c920.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.70%. Comparing base (a46b70e) to head (168c920).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/gmp/gmp.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5473      +/-   ##
==========================================
- Coverage   81.70%   81.70%   -0.01%     
==========================================
  Files        1283     1283              
  Lines       33650    33657       +7     
  Branches    10040    10041       +1     
==========================================
+ Hits        27493    27498       +5     
- Misses       5502     5504       +2     
  Partials      655      655              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daniele-mng
daniele-mng marked this pull request as ready for review August 3, 2026 11:04
@daniele-mng
daniele-mng requested a review from a team as a code owner August 3, 2026 11:04
@bjoernricks
bjoernricks enabled auto-merge (rebase) August 3, 2026 12:03
@bjoernricks
bjoernricks merged commit 31b0763 into main Aug 3, 2026
25 checks passed
@bjoernricks
bjoernricks deleted the GEA-1719 branch August 3, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants