Folding Improvements - #5534
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5534 +/- ##
==========================================
+ Coverage 83.99% 84.09% +0.10%
==========================================
Files 1290 1293 +3
Lines 33760 33766 +6
Branches 10089 10056 -33
==========================================
+ Hits 28356 28395 +39
+ Misses 4853 4821 -32
+ Partials 551 550 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ensure the behavior of the HOC.
Convert the wrapper component inside the HOC from a class component to a function component. Function components are easier to understand and to maintain.
bjoernricks
force-pushed
the
folding-improvements
branch
from
August 18, 2026 11:15
12f5600 to
2ec1380
Compare
Hooks are easier to understand.
Use the new hook instead the HOC.
The HOC got replaced with the useFoldToggle hook.
Keep things separated. With using an own module the HOC code will be easier to find.
With the refactoring of the Section component the types of the props passed to the Section are fixed now.
bjoernricks
force-pushed
the
folding-improvements
branch
from
August 18, 2026 11:20
2ec1380 to
d8127ef
Compare
bjoernricks
marked this pull request as ready for review
August 18, 2026 11:38
greenbonebot
enabled auto-merge (rebase)
August 18, 2026 11:38
bjoernricks
force-pushed
the
folding-improvements
branch
from
August 18, 2026 12:19
64cdf37 to
5e6396d
Compare
bjoernricks
force-pushed
the
folding-improvements
branch
from
August 18, 2026 12:21
5e6396d to
93df629
Compare
daniele-mng
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Folding Improvements
Why
Checklist