Skip to content

Fix clearing timer of SessionObserver - #5535

Merged
greenbonebot merged 1 commit into
mainfrom
session-observer
Aug 18, 2026
Merged

Fix clearing timer of SessionObserver#5535
greenbonebot merged 1 commit into
mainfrom
session-observer

Conversation

@bjoernricks

@bjoernricks bjoernricks commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

What

Fix clearing timer of SessionObserver

Why

Add tests for SessionObserver which discovered a bug in clearing a running timer during unmount.

Checklist

  • Tests

Add tests for SessionObserver which discovered a bug in clearing a
running time during unmount.
@bjoernricks
bjoernricks requested a review from a team as a code owner August 18, 2026 11:37
@greenbonebot
greenbonebot enabled auto-merge (rebase) August 18, 2026 11:38
@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 9dab77c.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.00%. Comparing base (cdfea48) to head (9dab77c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5535      +/-   ##
==========================================
+ Coverage   83.99%   84.00%   +0.01%     
==========================================
  Files        1290     1291       +1     
  Lines       33760    33792      +32     
  Branches    10089    10054      -35     
==========================================
+ Hits        28356    28387      +31     
- Misses       4853     4854       +1     
  Partials      551      551              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greenbonebot
greenbonebot merged commit f57f38f into main Aug 18, 2026
25 checks passed
@greenbonebot
greenbonebot deleted the session-observer branch August 18, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants