Fix clearing timer of SessionObserver - #5535
Merged
Merged
Conversation
Add tests for SessionObserver which discovered a bug in clearing a running time during unmount.
greenbonebot
enabled auto-merge (rebase)
August 18, 2026 11:38
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5535 +/- ##
==========================================
+ Coverage 83.99% 84.00% +0.01%
==========================================
Files 1290 1291 +1
Lines 33760 33792 +32
Branches 10089 10054 -35
==========================================
+ Hits 28356 28387 +31
- Misses 4853 4854 +1
Partials 551 551 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daniele-mng
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix clearing timer of SessionObserver
Why
Add tests for SessionObserver which discovered a bug in clearing a running timer during unmount.
Checklist