improve line chart labels - #5537
Draft
daniele-mng wants to merge 11 commits into
Draft
Conversation
Dependency ReviewThe following issues were found:
Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5537 +/- ##
=======================================
Coverage 84.25% 84.26%
=======================================
Files 1294 1293 -1
Lines 33817 33798 -19
Branches 10078 10083 +5
=======================================
- Hits 28494 28479 -15
Misses 4781 4781
+ Partials 542 538 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daniele-mng
force-pushed
the
improve-line-chart
branch
2 times, most recently
from
August 20, 2026 14:50
7ab2e50 to
5cb011d
Compare
- Added tests to verify point labels rendering based on the `showPointLabels` prop in LineChart. - Implemented hover info box behavior to stay within plot bounds. - Ensured range selection does not occur when an endpoint is removed before mouse up. refactor: Update Donut chart components - Refactored Labels component to accept arcs directly instead of raw data. - Adjusted Arc2d tests to wrap components in an SVG for proper rendering. - Removed unused 3D view functionality from DataDisplayIcons and related components. fix: Improve DashboardView loading state handling - Adjusted RowPlaceHolder height based on loading state. chore: Clean up dashboard display components - Removed 3D state management from various display components and tests. - Updated imports to reflect changes in DataDisplayIcons usage. - Ensured consistent handling of loading states across dashboard components.
daniele-mng
force-pushed
the
improve-line-chart
branch
from
August 25, 2026 06:51
5cb011d to
b7a7250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
References
Checklist