Skip to content

improve line chart labels - #5537

Draft
daniele-mng wants to merge 11 commits into
mainfrom
improve-line-chart
Draft

improve line chart labels#5537
daniele-mng wants to merge 11 commits into
mainfrom
improve-line-chart

Conversation

@daniele-mng

Copy link
Copy Markdown
Contributor

What

Why

References

Checklist

  • Tests

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
  • ⚠️ 2 packages with OpenSSF Scorecard issues.
See the Details below.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA b7a7250.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@types/d3-selection 3.0.11 🟢 6.6
Details
CheckScoreReason
Code-Review🟢 9Found 29/30 approved changesets -- score normalized to 9
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
npm/@types/d3-transition 3.0.9 🟢 6.6
Details
CheckScoreReason
Code-Review🟢 9Found 29/30 approved changesets -- score normalized to 9
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
npm/d3-ease 3.0.1 ⚠️ 2.7
Details
CheckScoreReason
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Code-Review⚠️ 2Found 5/20 approved changesets -- score normalized to 2
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
npm/d3-transition 3.0.1 ⚠️ 2.9
Details
CheckScoreReason
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Code-Review🟢 4Found 7/17 approved changesets -- score normalized to 4
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • package-lock.json

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.86441% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.26%. Comparing base (bc507ec) to head (b7a7250).

Files with missing lines Patch % Lines
src/web/components/chart/base/Line.tsx 82.00% 9 Missing ⚠️
src/gmp/commands/dashboards.ts 68.42% 6 Missing ⚠️
src/web/components/chart/donut/Arc2d.tsx 57.14% 6 Missing ⚠️
src/web/components/chart/HostsTopologyChart.tsx 63.63% 4 Missing ⚠️
src/web/components/chart/donut/Labels.tsx 91.89% 3 Missing ⚠️
src/web/components/chart/ScheduleChart.tsx 95.45% 1 Missing ⚠️
src/web/components/chart/base/Axis.tsx 92.85% 1 Missing ⚠️
...b/pages/tickets/dashboard/UsersAssignedDisplay.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5537   +/-   ##
=======================================
  Coverage   84.25%   84.26%           
=======================================
  Files        1294     1293    -1     
  Lines       33817    33798   -19     
  Branches    10078    10083    +5     
=======================================
- Hits        28494    28479   -15     
  Misses       4781     4781           
+ Partials      542      538    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daniele-mng
daniele-mng force-pushed the improve-line-chart branch 2 times, most recently from 7ab2e50 to 5cb011d Compare August 20, 2026 14:50
- Added tests to verify point labels rendering based on the `showPointLabels` prop in LineChart.
- Implemented hover info box behavior to stay within plot bounds.
- Ensured range selection does not occur when an endpoint is removed before mouse up.

refactor: Update Donut chart components

- Refactored Labels component to accept arcs directly instead of raw data.
- Adjusted Arc2d tests to wrap components in an SVG for proper rendering.
- Removed unused 3D view functionality from DataDisplayIcons and related components.

fix: Improve DashboardView loading state handling

- Adjusted RowPlaceHolder height based on loading state.

chore: Clean up dashboard display components

- Removed 3D state management from various display components and tests.
- Updated imports to reflect changes in DataDisplayIcons usage.
- Ensured consistent handling of loading states across dashboard components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant