Add tests for the withDialogNotification HOC - #5539
Merged
Merged
Conversation
greenbonebot
enabled auto-merge (rebase)
August 18, 2026 12:39
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
bjoernricks
force-pushed
the
with-dialog-notification-tests
branch
from
August 18, 2026 13:21
7724ad3 to
2f71bab
Compare
daniele-mng
approved these changes
Aug 18, 2026
daniele-mng
approved these changes
Aug 18, 2026
Ensure the withDialogNotification HOC behaves as expected.
bjoernricks
force-pushed
the
with-dialog-notification-tests
branch
from
August 18, 2026 14:16
2f71bab to
de9cdd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add tests for the withDialogNotification HOC
Why
As we still need this HOC because two other important HOCs (withEntityContainer and withEntitiesContainer) rely on it we
should snsure the withDialogNotification HOC behaves as expected.
Checklist